aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKim Alvefur <zash@zash.se>2017-01-28 21:39:14 +0100
committerKim Alvefur <zash@zash.se>2017-01-28 21:39:14 +0100
commitc5c11c2e2e6d2383ad901d34d417794f65d41679 (patch)
tree6c9cf0c2b8ff612f448ee3f99ed5f320126989e2
parent4ec8a2f5b5961e90db28d92afd1f685966d8fe42 (diff)
parentb661ee3acae5202256b1cd6492bdd6feac8db8bd (diff)
downloadprosody-c5c11c2e2e6d2383ad901d34d417794f65d41679.tar.gz
prosody-c5c11c2e2e6d2383ad901d34d417794f65d41679.zip
Merge 0.10->trunk
-rw-r--r--.luacheckrc3
-rw-r--r--plugins/mod_component.lua30
-rw-r--r--plugins/mod_pep.lua7
3 files changed, 25 insertions, 15 deletions
diff --git a/.luacheckrc b/.luacheckrc
index 90d2e273..80c903c3 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -7,6 +7,9 @@ unused_secondaries = false
codes = true
ignore = { "411/err", "421/err", "411/ok", "421/ok", "211/_ENV" }
+files["core/"] = {
+ ignore = { "122/prosody", "122/hosts" };
+}
files["plugins/"] = {
globals = { "module" };
}
diff --git a/plugins/mod_component.lua b/plugins/mod_component.lua
index 2ef2533b..cf678933 100644
--- a/plugins/mod_component.lua
+++ b/plugins/mod_component.lua
@@ -33,7 +33,7 @@ function module.add_host(module)
if module:get_host_type() ~= "component" then
error("Don't load mod_component manually, it should be for a component, please see https://prosody.im/doc/components", 0);
end
-
+
local env = module.environment;
env.connected = false;
env.session = false;
@@ -46,26 +46,26 @@ function module.add_host(module)
send = nil;
session.on_destroy = nil;
end
-
+
-- Handle authentication attempts by component
local function handle_component_auth(event)
local session, stanza = event.origin, event.stanza;
-
+
if session.type ~= "component_unauthed" then return; end
-
+
if (not session.host) or #stanza.tags > 0 then
(session.log or log)("warn", "Invalid component handshake for host: %s", session.host);
session:close("not-authorized");
return true;
end
-
+
local secret = module:get_option("component_secret");
if not secret then
(session.log or log)("warn", "Component attempted to identify as %s, but component_secret is not set", session.host);
session:close("not-authorized");
return true;
end
-
+
local supplied_token = t_concat(stanza);
local calculated_token = sha1(session.streamid..secret, true);
if supplied_token:lower() ~= calculated_token:lower() then
@@ -73,7 +73,7 @@ function module.add_host(module)
session:close{ condition = "not-authorized", text = "Given token does not match calculated token" };
return true;
end
-
+
if env.connected then
local policy = module:get_option_string("component_conflict_resolve", "kick_new");
if policy == "kick_old" then
@@ -84,7 +84,7 @@ function module.add_host(module)
return true;
end
end
-
+
env.connected = true;
env.session = session;
send = session.send;
@@ -94,7 +94,7 @@ function module.add_host(module)
module:log("info", "External component successfully authenticated");
session.send(st.stanza("handshake"));
module:fire_event("component-authenticated", { session = session });
-
+
return true;
end
module:hook("stanza/jabber:component:accept:handshake", handle_component_auth, -1);
@@ -125,7 +125,7 @@ function module.add_host(module)
end
return true;
end
-
+
module:hook("iq/bare", handle_stanza, -1);
module:hook("message/bare", handle_stanza, -1);
module:hook("presence/bare", handle_stanza, -1);
@@ -282,14 +282,14 @@ function listener.onconnect(conn)
if opt_keepalives then
conn:setoption("keepalive", opt_keepalives);
end
-
+
session.log("info", "Incoming Jabber component connection");
-
+
local stream = new_xmpp_stream(session, stream_callbacks);
session.stream = stream;
-
+
session.notopen = true;
-
+
function session.reset_stream()
session.notopen = true;
session.stream:reset();
@@ -301,7 +301,7 @@ function listener.onconnect(conn)
module:log("debug", "Received invalid XML (%s) %d bytes: %s", tostring(err), #data, data:sub(1, 300):gsub("[\r\n]+", " "):gsub("[%z\1-\31]", "_"));
session:close("not-well-formed");
end
-
+
session.dispatch_stanza = stream_callbacks.handlestanza;
sessions[conn] = session;
diff --git a/plugins/mod_pep.lua b/plugins/mod_pep.lua
index 46517b95..5d6485fa 100644
--- a/plugins/mod_pep.lua
+++ b/plugins/mod_pep.lua
@@ -185,7 +185,11 @@ module:hook("iq/bare/http://jabber.org/protocol/pubsub:pubsub", function(event)
node = node, user = jid_bare(session.full_jid), actor = session.jid, id = id, session = session, item = st.clone(payload);
});
return true;
+ else
+ module:log("debug", "Payload is missing the <item>", node);
end
+ else
+ module:log("debug", "Unhandled payload: %s", payload and payload:top_tag() or "(no payload)");
end
elseif stanza.attr.type == 'get' then
local user = stanza.attr.to and jid_bare(stanza.attr.to) or session.username..'@'..session.host;
@@ -221,14 +225,17 @@ module:hook("iq/bare/http://jabber.org/protocol/pubsub:pubsub", function(event)
end
elseif node then -- node doesn't exist
session.send(st.error_reply(stanza, 'cancel', 'item-not-found'));
+ module:log("debug", "Item '%s' not found", node)
return true;
else --invalid request
session.send(st.error_reply(stanza, 'modify', 'bad-request'));
+ module:log("debug", "Invalid request: %s", tostring(payload));
return true;
end
else --no presence subscription
session.send(st.error_reply(stanza, 'auth', 'not-authorized')
:tag('presence-subscription-required', {xmlns='http://jabber.org/protocol/pubsub#errors'}));
+ module:log("debug", "Unauthorized request: %s", tostring(payload));
return true;
end
end