diff options
| author | Kim Alvefur <zash@zash.se> | 2019-12-07 17:05:00 +0100 |
|---|---|---|
| committer | Kim Alvefur <zash@zash.se> | 2019-12-07 17:05:00 +0100 |
| commit | 40ffc88bad91782bf8564994826b528609004751 (patch) | |
| tree | 661936621e69aff3b5fcc127d81e09c71b616bcc | |
| parent | 2d5eaff749da055df6a29f20a169759f0bc96479 (diff) | |
| download | prosody-40ffc88bad91782bf8564994826b528609004751.tar.gz prosody-40ffc88bad91782bf8564994826b528609004751.zip | |
net.connect: Add some TODOs and FIXMEs
And mention issue numbers: #1246, #1428 and #1429
| -rw-r--r-- | net/connect.lua | 4 | ||||
| -rw-r--r-- | net/resolvers/basic.lua | 4 | ||||
| -rw-r--r-- | net/resolvers/service.lua | 3 |
3 files changed, 10 insertions, 1 deletions
diff --git a/net/connect.lua b/net/connect.lua index 0e11bd3e..fe70ce36 100644 --- a/net/connect.lua +++ b/net/connect.lua @@ -3,8 +3,10 @@ local log = require "util.logger".init("net.connect"); local new_id = require "util.id".short; -- TODO Respect use_ipv4, use_ipv6 +-- TODO #1246 Happy Eyeballs -- FIXME Error propagation from resolvers doesn't work --- TODO Try to share DNS resolver object and close it afterwards +-- FIXME #1428 Reuse DNS resolver object between service and basic resolver +-- FIXME #1429 Close DNS resolver object when done local pending_connection_methods = {}; local pending_connection_mt = { diff --git a/net/resolvers/basic.lua b/net/resolvers/basic.lua index c1931dab..ef69e6dc 100644 --- a/net/resolvers/basic.lua +++ b/net/resolvers/basic.lua @@ -7,6 +7,10 @@ local unpack = table.unpack or unpack; -- luacheck: ignore 113 local methods = {}; local resolver_mt = { __index = methods }; +-- TODO Respect use_ipv4, use_ipv6 +-- FIXME #1428 Reuse DNS resolver object (from service resolver) +-- FIXME #1429 Close DNS resolver object when done + -- Find the next target to connect to, and -- pass it to cb() function methods:next(cb) diff --git a/net/resolvers/service.lua b/net/resolvers/service.lua index 504fb421..b4300d08 100644 --- a/net/resolvers/service.lua +++ b/net/resolvers/service.lua @@ -4,6 +4,9 @@ local inet_pton = require "util.net".pton; local idna_to_ascii = require "util.encodings".idna.to_ascii; local unpack = table.unpack or unpack; -- luacheck: ignore 113 +-- FIXME #1428 Reuse DNS resolver object (pass to basic resorver) +-- FIXME #1429 Close DNS resolver object when done + local methods = {}; local resolver_mt = { __index = methods }; |