aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Wild <mwild1@gmail.com>2013-07-08 21:38:08 +0100
committerMatthew Wild <mwild1@gmail.com>2013-07-08 21:38:08 +0100
commitfb9838c64b97cd51c87a6cc251a6049e11eeba94 (patch)
treecb199d278486960f43ecb1f7a0becf9aaa11ca32
parent94bc9e826da5f85b9e3c024514f293e86f822c34 (diff)
downloadprosody-fb9838c64b97cd51c87a6cc251a6049e11eeba94.tar.gz
prosody-fb9838c64b97cd51c87a6cc251a6049e11eeba94.zip
mod_component: xpcall() stanza processing, as per other listeners, preventing potentially harmful 'top-level errors'
-rw-r--r--plugins/mod_component.lua7
1 files changed, 6 insertions, 1 deletions
diff --git a/plugins/mod_component.lua b/plugins/mod_component.lua
index 871a20e4..2fde57ee 100644
--- a/plugins/mod_component.lua
+++ b/plugins/mod_component.lua
@@ -9,6 +9,7 @@
module:set_global();
local t_concat = table.concat;
+local traceback = debug.traceback;
local logger = require "util.logger";
local sha1 = require "util.hashes".sha1;
@@ -183,6 +184,7 @@ function stream_callbacks.streamclosed(session)
session:close();
end
+local function handleerr(err) log("error", "Traceback[component]: %s", traceback(tostring(err), 2)); end
function stream_callbacks.handlestanza(session, stanza)
-- Namespaces are icky.
if not stanza.attr.xmlns and stanza.name == "handshake" then
@@ -213,7 +215,10 @@ function stream_callbacks.handlestanza(session, stanza)
return;
end
end
- return core_process_stanza(session, stanza);
+
+ if stanza then
+ return xpcall(function () return core_process_stanza(session, stanza) end, handleerr);
+ end
end
--- Closing a component connection