diff options
| author | Kim Alvefur <zash@zash.se> | 2020-06-14 12:57:50 +0200 |
|---|---|---|
| committer | Kim Alvefur <zash@zash.se> | 2020-06-14 12:57:50 +0200 |
| commit | 9ea29301ad2334abdb9bffa85f12ff631692bdf3 (patch) | |
| tree | e09825d859a6b02834c62625e3244e48d2129b74 | |
| parent | 020454b7a3afe41edcc365f593bffc97c827e962 (diff) | |
| download | prosody-9ea29301ad2334abdb9bffa85f12ff631692bdf3.tar.gz prosody-9ea29301ad2334abdb9bffa85f12ff631692bdf3.zip | |
util.prosodyctl.check: Fix traceback by handling SRV '.' target to
The IDNA to-ASCII operation returns nil in this case, which causes an
error in net.dns
| -rw-r--r-- | util/prosodyctl/check.lua | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/util/prosodyctl/check.lua b/util/prosodyctl/check.lua index d22d5f45..ca5c51c9 100644 --- a/util/prosodyctl/check.lua +++ b/util/prosodyctl/check.lua @@ -299,6 +299,10 @@ local function check(arg) local res = dns.lookup("_xmpp-client._tcp."..idna.to_ascii(host)..".", "SRV"); if res then for _, record in ipairs(res) do + if record.srv.target == "." then -- TODO is this an error if mod_c2s is enabled? + print(" 'xmpp-client' service disabled by pointing to '.'"); -- FIXME Explain better what this is + break; + end target_hosts:add(record.srv.target); if not c2s_ports:contains(record.srv.port) then print(" SRV target "..record.srv.target.." contains unknown client port: "..record.srv.port); @@ -317,6 +321,10 @@ local function check(arg) local res = dns.lookup("_xmpp-server._tcp."..idna.to_ascii(host)..".", "SRV"); if res then for _, record in ipairs(res) do + if record.srv.target == "." then -- TODO Is this an error if mod_s2s is enabled? + print(" 'xmpp-server' service disabled by pointing to '.'"); -- FIXME Explain better what this is + break; + end target_hosts:add(record.srv.target); if not s2s_ports:contains(record.srv.port) then print(" SRV target "..record.srv.target.." contains unknown server port: "..record.srv.port); |