diff options
| author | Kim Alvefur <zash@zash.se> | 2020-05-05 23:08:47 +0200 |
|---|---|---|
| committer | Kim Alvefur <zash@zash.se> | 2020-05-05 23:08:47 +0200 |
| commit | 405ba6df12d248331d74dfb8ec93bc1321b9056a (patch) | |
| tree | 43dc06f0931667d4f3c4b3d98e2729d7b9eaacf6 | |
| parent | ebf52208e4105478eebcac3440ceaf58f6630cff (diff) | |
| download | prosody-405ba6df12d248331d74dfb8ec93bc1321b9056a.tar.gz prosody-405ba6df12d248331d74dfb8ec93bc1321b9056a.zip | |
mod_csi_simple: Don't consider presence errors as important
A large share of `<presence type=error>` appears to be noise from large
public channels and failed presence probes. The later at least should
count as presence updates, which are currently considered unimportant.
See also 8cecb85e4bc4 which is partly reverted here. The intent there
was probably mostly about message (delivery) errors, which should be
considered important.
| -rw-r--r-- | plugins/mod_csi_simple.lua | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/plugins/mod_csi_simple.lua b/plugins/mod_csi_simple.lua index d3bf3a9f..05650957 100644 --- a/plugins/mod_csi_simple.lua +++ b/plugins/mod_csi_simple.lua @@ -28,18 +28,19 @@ module:hook("csi-is-stanza-important", function (event) local st_name = stanza.name; if not st_name then return false; end local st_type = stanza.attr.type; - if st_type == "error" then - return true; - end if st_name == "presence" then - if st_type == nil or st_type == "unavailable" then + if st_type == nil or st_type == "unavailable" or st_name == "error" then return false; end + -- TODO Some MUC awareness, e.g. check for the 'this relates to you' status code return true; elseif st_name == "message" then if st_type == "headline" then return false; end + if st_type == "error" then + return true; + end if stanza:get_child("sent", "urn:xmpp:carbons:2") then return true; end |