diff options
| author | Kim Alvefur <zash@zash.se> | 2021-02-25 23:58:08 +0100 |
|---|---|---|
| committer | Kim Alvefur <zash@zash.se> | 2021-02-25 23:58:08 +0100 |
| commit | a2648b9d649df6caa39b36317cc9508545b78d98 (patch) | |
| tree | 16ee90371075ef13ce1ab49169259850569f0d0d /CONTRIBUTING | |
| parent | fcaf27fc8abded1ef0c3ea2a6302d25749013837 (diff) | |
| download | prosody-a2648b9d649df6caa39b36317cc9508545b78d98.tar.gz prosody-a2648b9d649df6caa39b36317cc9508545b78d98.zip | |
mod_http_file_share: Remove correct entries when not all expired files were deleted
If any of the expired files could not be deleted then we should not
forget about that, we should complain loudly and try again.
The code got this backwards and would have removed only the entries
referring to still existing files.
Test procedure:
1. Upload a file
2. chown root:root http_file_share/
3. In uploads.list, decrease 'when' enough to ensure expiry
4. Reload mod_http_file_share
5. Should see an error in the logs about failure to delete the file
6. Should see that the metadata in uploads.list is still there
7. chown http_file_share/ back to the previous owner
8. Reload mod_http_file_share
9. Should see logs about successful removal of expired file
10. Should see that the metadata in uploads.list is gone
11. Should see that the file was deleted
Diffstat (limited to 'CONTRIBUTING')
0 files changed, 0 insertions, 0 deletions