sessionmanager: If roster loading fails during resource bind, kick the user with an internal-server-error.

1 files changed, 13 insertions, 1 deletions

diff --git a/core/sessionmanager.lua b/core/sessionmanager.lua
index 6e771a84..3537d2d2 100644
--- a/core/sessionmanager.lua
+++ b/core/sessionmanager.lua
@@ -174,7 +174,19 @@ function bind_resource(session, resource)
 	hosts[session.host].sessions[session.username].sessions[resource] = session;
 	full_sessions[session.full_jid] = session;
 	
-	session.roster = rm_load_roster(session.username, session.host);
+	local err;
+	session.roster, err = rm_load_roster(session.username, session.host);
+	if err then
+		full_sessions[session.full_jid] = nil;
+		hosts[session.host].sessions[session.username].sessions[resource] = nil;
+		session.full_jid = nil;
+		session.resource = nil;
+		if next(bare_sessions[session.username..'@'..session.host]) == nil then
+			bare_sessions[session.username..'@'..session.host] = nil;
+			hosts[session.host].sessions[session.username] = nil;
+		end
+		return nil, "cancel", "internal-server-error", "Error loading roster";
+	end
 	
 	hosts[session.host].events.fire_event("resource-bind", {session=session});