aboutsummaryrefslogtreecommitdiffstats
path: root/spec
diff options
context:
space:
mode:
authorMatthew Wild <mwild1@gmail.com>2023-02-17 17:01:19 +0000
committerMatthew Wild <mwild1@gmail.com>2023-02-17 17:01:19 +0000
commit87ee5a2300ef296fc3c11e6d3d1c9be23d289252 (patch)
tree05c9ff9930ebabadac3e12b495a9319f5c4b6fb9 /spec
parent67ea0ee50ecd5886099e639f847acff9f28fd6e2 (diff)
downloadprosody-87ee5a2300ef296fc3c11e6d3d1c9be23d289252.tar.gz
prosody-87ee5a2300ef296fc3c11e6d3d1c9be23d289252.zip
net.http.parser: Fix off-by-one error in chunk parser
Diffstat (limited to 'spec')
-rw-r--r--spec/net_http_parser_spec.lua53
1 files changed, 50 insertions, 3 deletions
diff --git a/spec/net_http_parser_spec.lua b/spec/net_http_parser_spec.lua
index ed70c431..9da8ca73 100644
--- a/spec/net_http_parser_spec.lua
+++ b/spec/net_http_parser_spec.lua
@@ -8,18 +8,48 @@ local function CRLF(s)
end
local function test_stream(stream, expect)
+ local chunks_processed = 0;
local success_cb = spy.new(function (packet)
assert.is_table(packet);
if packet.body ~= false then
assert.is_equal(expect.body, packet.body);
end
+ if expect.chunks then
+ if chunks_processed == 0 then
+ assert.is_true(packet.partial);
+ packet.body_sink = {
+ write = function (_, data)
+ chunks_processed = chunks_processed + 1;
+ assert.equal(expect.chunks[chunks_processed], data);
+ return true;
+ end;
+ };
+ end
+ end
end);
- local parser = http_parser.new(success_cb, error, stream:sub(1,4) == "HTTP" and "client" or "server")
- for chunk in stream:gmatch("."..string.rep(".?", parser_input_bytes-1)) do
- parser:feed(chunk);
+ local function options_cb()
+ return {
+ -- Force streaming API mode
+ body_size_limit = expect.chunks and 0 or nil;
+ buffer_size_limit = 10*1024*2;
+ };
+ end
+
+ local parser = http_parser.new(success_cb, error, (stream[1] or stream):sub(1,4) == "HTTP" and "client" or "server", options_cb)
+ if type(stream) == "string" then
+ for chunk in stream:gmatch("."..string.rep(".?", parser_input_bytes-1)) do
+ parser:feed(chunk);
+ end
+ else
+ for _, chunk in ipairs(stream) do
+ parser:feed(chunk);
+ end
end
+ if expect.chunks then
+ assert.equal(chunks_processed, #expect.chunks);
+ end
assert.spy(success_cb).was_called(expect.count or 1);
end
@@ -120,6 +150,23 @@ o
}
);
end);
+
+ it("should correctly find chunk boundaries", function ()
+ test_stream({
+
+CRLF[[
+HTTP/1.1 200 OK
+Transfer-Encoding: chunked
+
+]].."3\r\n:)\n\r\n"},
+ {
+ count = 1; -- Once (partial)
+ chunks = {
+ ":)\n"
+ };
+ }
+ );
+ end);
end);
it("should handle large chunked responses", function ()