aboutsummaryrefslogtreecommitdiffstats
path: root/spec
diff options
context:
space:
mode:
authorMatthew Wild <mwild1@gmail.com>2025-03-11 18:27:36 +0000
committerMatthew Wild <mwild1@gmail.com>2025-03-11 18:27:36 +0000
commit06994f0bc145ebf61b7906a715f61f22a70cbe57 (patch)
tree8f326fa3cb543584b7eb8677395eb6dbf385558c /spec
parentafb9bc34a098a4911effdda36c69a04aca821558 (diff)
downloadprosody-06994f0bc145ebf61b7906a715f61f22a70cbe57.tar.gz
prosody-06994f0bc145ebf61b7906a715f61f22a70cbe57.zip
util.argparse: Fix bug (regression?) in argument parsing with --foo=bar
After recent changes, '--foo bar' was working, but '--foo=bar' was not. The test had a typo (?) (bar != baz) and because util.argparse is not strict by default, the typo was not caught. The typo caused the code to take a different path, and bypassed the buggy handling of --foo=bar options. I've preserved the existing test (typo and all!) because it's still an interesting test, and ensures no unintended behaviour changes compared to the old code. However I've added a new variant of the test, with strict mode enabled and the typo fixed. This test failed due to the bug, and this commit introduces a fix.
Diffstat (limited to 'spec')
-rw-r--r--spec/util_argparse_spec.lua6
1 files changed, 6 insertions, 0 deletions
diff --git a/spec/util_argparse_spec.lua b/spec/util_argparse_spec.lua
index be1d99df..3fd4070e 100644
--- a/spec/util_argparse_spec.lua
+++ b/spec/util_argparse_spec.lua
@@ -54,6 +54,12 @@ describe("parse", function()
assert.same({ foo = "bar"; baz = "moo" }, opts);
end);
+ it("supports value arguments in strict mode", function()
+ local opts, err = parse({ "--foo"; "bar"; "--baz=moo" }, { strict = true, value_params = { foo = true; baz = true } });
+ assert.falsy(err);
+ assert.same({ foo = "bar"; baz = "moo" }, opts);
+ end);
+
it("demands values for value params", function()
local opts, err, where = parse({ "--foo" }, { value_params = { foo = true } });
assert.falsy(opts);