util.datamanager: In append() collect status when closing file handle as it may fail (eg the implied flush)

1 files changed, 9 insertions, 3 deletions

diff --git a/util/datamanager.lua b/util/datamanager.lua
index 1993d6a3..4a371d2c 100644
--- a/util/datamanager.lua
+++ b/util/datamanager.lua
@@ -210,9 +210,10 @@ local function store(username, host, datastore, data)
 end
 
 local function append(username, host, datastore, ext, data)
-	local f, msg = io_open(getpath(username, host, datastore, ext, true), "r+");
+	local filename = getpath(username, host, datastore, ext, true);
+	local f, msg = io_open(filename, "r+");
 	if not f then
-		f, msg = io_open(getpath(username, host, datastore, ext, true), "w");
+		f, msg = io_open(filename, "w");
 	end
 	if not f then
 		return nil, msg;
@@ -225,7 +226,12 @@ local function append(username, host, datastore, ext, data)
 	else
 		return ok, msg;
 	end
-	f:close();
+
+	ok, msg = f:close();
+	if not ok then
+		return ok, msg;
+	end
+
 	return true;
 end