aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* net.httpserver: Remove obsolete APIMatthew Wild7 days1-17/+0
|
* prosody.cfg.lua.dist: Updates for 13.0+Matthew Wild8 days1-2/+4
|
* CHANGES: List mod_cloud_notifyMatthew Wild8 days1-0/+1
|
* MUC: Use new XEP namespace for hats by defaultMatthew Wild8 days1-1/+1
| | | | Revert with muc_hats_compat = true in the config if necessary.
* prosodyctl: check: Warn about deprecated mod_posixMatthew Wild8 days1-0/+6
|
* modulemanager: Remove autoloading of per-platform moduleMatthew Wild8 days1-1/+0
| | | | | We only support posix these days, and we moved it to the core startup process to make it more deterministic and reliable.
* mod_admin_shell: Remove duplicated lineMatthew Wild8 days1-2/+0
|
* mod_admin_shell: Rename user:setrole to user:set_rolesMatthew Wild8 days1-4/+4
| | | | | This is more readable and accessible, and it will only be harder to change after release.
* mod_admin_shell: Hide secondary role commands, focus on primary rolesMatthew Wild8 days1-7/+17
| | | | | | | | | Secondary roles are an advanced feature without any strong use cases currently. Having multiple ways to manage roles is confusing. Now the 'user:role' command will just show the primary role if that is all there is, but will list secondary roles too if there are any (which in 99.9% of cases there won't be).
* mod_admin_shell: Support for hiding certain commands from default help listingMatthew Wild8 days1-5/+8
| | | | Useful for e.g. deprecated commands.
* mod_account_activity: Fix error when no duration specified in shell commandMatthew Wild8 days1-1/+1
|
* mod_admin_shell: Fix result handling of user addrole/delrole commandsMatthew Wild8 days1-2/+10
|
* usermanager: Include role_name in event for consistency with the 'removed' eventMatthew Wild8 days1-1/+1
|
* mod_authz_internal: Fix error messagesMatthew Wild8 days1-2/+2
|
* mod_authz_internal: Fix return values of secondary role management methodsMatthew Wild8 days1-3/+8
| | | | usermanager expects (role, err) and (ok, err)
* mod_presence: Fix traceback if origin gets disconnected during processingMatthew Wild9 days1-2/+10
| | | | Fixes #1887
* mod_invites: Add shell commands to list, show and delete pending invitationsMatthew Wild9 days1-0/+140
|
* mod_invites: Shell command to create reset linksMatthew Wild9 days1-0/+18
|
* core.configmanager: Delay reporting warnings about Credential until useKim Alvefur9 days1-3/+16
| | | | | | Too much noise to use Credential if you get a pile of warnings every time you touch prosodyctl for anything. This way warnings should be printed only if e.g used by prosodyctl check config or a module command.
* CHANGES: Update with some more 13.0 featuresMatthew Wild9 days1-0/+2
|
* mod_account_activity: Add shell command to list inactive accountsMatthew Wild9 days1-0/+43
| | | | Including accounts which may never have logged in.
* mod_account_activity: Fix required module namesMatthew Wild9 days1-3/+3
|
* mod_account_activity: Record an account's last activity timestampMatthew Wild10 days1-0/+109
| | | | | | | | | | | | | This is similar to mod_lastlog/mod_lastlog2. Some functionality was dropped, compared to mod_lastlog2. These features (recording the IP address, or tracking the timestamp of multiple events) are handled better by the mod_audit family of modules. For example, those correctly handle multiple logins, IP address truncation, and data retention policies. The "registered" timestamp from mod_lastlog2 was also dropped, as this has been stored in account_details by Prosody itself since at least 0.12 already.
* CHANGES: Update for 13.0.xMatthew Wild10 days1-0/+3
|
* util.dnsregistry: Update using scriptKim Alvefur12 days1-1/+2
|
* tools.dnsregistry: Comment out duplicate error codesKim Alvefur12 days1-1/+4
| | | | This has previously been done manually after running this script
* mod_storage_sql: Fix tests for SQLite3Kim Alvefur14 days1-1/+1
| | | | Tests does not run the code that initializes `sqlite_version`
* MUC: Don't inform people about the avatar hash when there is noneMatthew Wild2025-02-071-0/+1
|
* net.adns: Collect DNS lookup timing metricsKim Alvefur2025-02-073-5/+34
| | | | Nice to have this in OpenMetricts instead of debug logs
* mod_vcard: Switch store name for MUC hosts (thanks lissine)Matthew Wild2025-02-061-2/+8
|
* mod_muc: Integrate support for vcards/avatars on MUC roomsMatthew Wild2025-02-063-0/+87
| | | | | | This was previously served by a community module (mod_vcard_muc). It can be disabled by setting `vcard_muc = false` in the config.
* mod_vcard: Some support for handling vcards on componentsMatthew Wild2025-02-061-3/+7
|
* mod_vcard: Fire event when vcard updatedMatthew Wild2025-02-061-0/+1
|
* mod_vcard: Add API to get hash of the vcard avatarMatthew Wild2025-02-061-0/+13
|
* prosodyctl: Fix check for whether to show init system warningMatthew Wild2025-02-061-1/+1
| | | | Overlooked from testing.
* net.server_epoll: Call :shutdown() on TLS sockets when supportedMartijn van Duren2025-02-061-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Comment from Matthew: This fixes a potential issue where the Prosody process gets blocked on sockets waiting for them to close. Unlike non-TLS sockets, closing a TLS socket sends layer 7 data, and this can cause problems for sockets which are in the process of being cleaned up. This depends on LuaSec changes which are not yet upstream. From Martijn's original email: So first my analysis of luasec. in ssl.c the socket is put into blocking mode right before calling SSL_shutdown() inside meth_destroy(). My best guess to why this is is because meth_destroy is linked to the __close and __gc methods, which can't exactly be called multiple times and luasec does want to make sure that a tls session is shutdown as clean as possible. I can't say I disagree with this reasoning and don't want to change this behaviour. My solution to this without changing the current behaviour is to introduce a shutdown() method. I am aware that this overlaps in a conflicting way with tcp's shutdown method, but it stays close to the OpenSSL name. This method calls SSL_shutdown() in the current (non)blocking mode of the underlying socket and returns a boolean whether or not the shutdown is completed (matching SSL_shutdown()'s 0 or 1 return values), and returns the familiar ssl_ioerror() strings on error with a false for completion. This error can then be used to determine if we have wantread/wantwrite to finalize things. Once meth_shutdown() has been called once a shutdown flag will be set, which indicates to meth_destroy() that the SSL_shutdown() has been handled by the application and it shouldn't be needed to set the socket to blocking mode. I've left the SSL_shutdown() call in the LSEC_STATE_CONNECTED to prevent TOCTOU if the application reaches a timeout for the shutdown code, which might allow SSL_shutdown() to clean up anyway at the last possible moment. Another thing I've changed to luasec is the call to socket_setblocking() right before calling close(2) in socket_destroy() in usocket.c. According to the latest POSIX[0]: Note that the requirement for close() on a socket to block for up to the current linger interval is not conditional on the O_NONBLOCK setting. Which I read to mean that removing O_NONBLOCK on the socket before close doesn't impact the behaviour and only causes noise in system call tracers. I didn't touch the windows bits of this, since I don't do windows. For the prosody side of things I've made the TLS shutdown bits resemble interface:onwritable(), and put it under a combined guard of self._tls and self.conn.shutdown. The self._tls bit is there to prevent getting stuck on this condition, and self.conn.shutdown is there to prevent the code being called by instances where the patched luasec isn't deployed. The destroy() method can be called from various places and is read by me as the "we give up" error path. To accommodate for these unexpected entrypoints I've added a single call to self.conn:shutdown() to prevent the socket being put into blocking mode. I have no expectations that there is any other use here. Same as previous, the self.conn.shutdown check is there to make sure it's not called on unpatched luasec deployments and self._tls is there to make sure we don't call shutdown() on tcp sockets. I wouldn't recommend logging of the conn:shutdown() error inside close(), since a lot of clients simply close the connection before SSL_shutdown() is done.
* prosodyctl: Further deprecate start/stop/restart commands when installedMatthew Wild2025-02-061-11/+35
| | | | | | | | | | | | | | | Despite the warning we introduced, many people continue to try using prosodyctl to manage Prosody in the presence of systemctl (e.g. #1688). Also, despite the warning, prosodyctl proceeded with the operation. This means the commands could be invoked by accident, and cause a situation that is hard to recover from (needing to manually track down stray processes). This commit disables all the problematic commands by default, but this can still be overridden using --force or via a config option. We only perform this check when we believe Prosody has been "installed" for system-wide use (i.e. running it from a source directory is still supported).
* prosodyctl: reload: Assume reload-via-socket if any arguments passedMatthew Wild2025-02-061-0/+3
|
* prosodyctl: Fix luacheck warningMatthew Wild2025-02-061-1/+1
|
* prosodyctl: reload: Remove redundant requireMatthew Wild2025-02-061-1/+0
|
* util.prosodyctl: Add comments to explain logic and expected behaviour (#1688)Matthew Wild2025-02-061-0/+7
|
* prosodyctl: stop: Fix detection of whether Prosody is runningMatthew Wild2025-02-061-1/+5
|
* prosodyctl: reload: Fix detection of whether prosody is runningMatthew Wild2025-02-061-3/+5
| | | | | isrunning() returns two values (success, status) and we were only checking the first one.
* prosodyctl: reload: use admin socket to issue reload command, if availableMatthew Wild2025-02-061-7/+11
|
* util.prosodyctl.shell: Export function to check for availability of admin socketMatthew Wild2025-02-061-0/+8
|
* mod_c2s: Add debug log when disconnecting all user sessionsMatthew Wild2025-02-061-0/+1
|
* mod_admin_shell: Fix column alignment in 'help roles'Kim Alvefur2025-02-021-1/+1
|
* mod_admin_shell: Fix help forgetting argumentsKim Alvefur2025-02-021-1/+1
| | | | | | The array:pluck() method mutates the args, replacing the table items with the resulting strings. On later runs I assume it tries to index the string, which returns nil, emptying the array.
* util.startup: Drop mention of systemd from notification socket handlingKim Alvefur2025-02-011-4/+4
| | | | This does not have to be specific to systemd
* mod_tokenauth: Fix expiry lasting one second too muchRĂ©mi Bardon2025-02-011-5/+5
| | | | | | | | | Because the code was using `< now` in a lot of places, things expiring at the current second wouldn't be marked as expired. It isn't noticeable in real-world scenarios but I wanted to create OAuth 2.0 tokens valid for 0 second in integration tests and it wasn't possible. By using `<=` instead of `<`, we make sure tokens don't live a single millisecond more than what they are supposed to.