| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| | |
Not necessarily a fix, but may give us more information about failure cases.
|
| |
| |
| |
| |
| |
| |
| | |
Looks like I forgot to update these when merging the channel binding
changes after the great renamening.
Ref #1223
|
| |
| |
| |
| |
| |
| | |
Seems to be hard to break old habits?
Ref #1223
|
| | |
|
| |
| |
| |
| |
| | |
This is the Right Thing and should fix various potential issues and race
conditions.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows certain session-specific code that needs to run in the async
context, but is itself triggered outside of that context (e.g. timers), to
be queued.
An example of this is the session destruction code of mod_smacks, when the
hibernation timeout is reached.
|
| |
| |
| |
| | |
Now we can, for example, read/write pipes using Lua's standard I/O routines.
|
| | |
|
| |
| |
| |
| |
| | |
This shouldn't be possible, but seems to happen anyway after net.server
somehow calling the close handler twice, which also should not happen.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Attempt to fix a bug where connections are somehow closed twice, leading
to bad things happening elsewhere.
With LuaSec, closed connections are generally already too closed to
write anything to anyway since it does not support unidirectional
shutdown.
|
| |
| |
| |
| | |
Added in f0b2c026e542 and not sure why
|
| | |
|
| |
| |
| |
| |
| |
| | |
More correct handling of namespaces here.
This works with both prefixes from the parser and hacky .attr["foo:bar"]
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Attributes are strings. That definitely is a number. So we
tostring() it. This is important when the API becomes stricter,
for whatever reason that might happen.
Practically, this moves the overhead of converting to a string
to a place where it is visible.
|
| |
| |
| |
| | |
Otherwise no syslog or console detection
|
| |
| |
| |
| | |
Otherwise Prosody refuses to start.
|
| | |
|
| |
| |
| |
| | |
Hopefully less confusing than "Module loaded onto 0 hosts"
|
| |
| |
| |
| | |
Meant to improve clarity and make improving easier
|
|\| |
|
| |
| |
| |
| |
| | |
This avoids doing performing unnecessary work in the case of visitors joining
a MUC, no functionality changes are intended.
|
| | |
|
| |
| |
| |
| |
| | |
Some confusion happened in 42b98ee73ca8, possibly because .count()
returns the items?
|
| |
| |
| |
| |
| |
| |
| | |
This clone call was lost in 902d25cd0557
Affects e.g. presence broadcasts, where the same stanza is sent many
times while mutating the 'to' attribute.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This queue is used to buffer stanzas while waiting for an outgoing s2s
connection to be established.
Limit it to prevent excessive memory usage.
Default chosen to approximate how many average stanzas fits in the
server_epoll default max_send_buffer_size of 32 MiB
Returns a custom error instead of the default core.stanza_router
"Communication with remote domains is not enabled" from is sent back,
which does not describe what is happening here.
Closes #1106
|
| |
| |
| |
| |
| |
| |
| | |
Prevent Bad Things from happening when the buffer gets full.
This of course opens up the possibility of intentionally killing
connections by sending much stuff, which need to be mitigated with rate
limits elsewhere.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Problem: The string slice operations when a lot of data gets buffered
ends up being expensive and memory-consuming. We have util.dbuffer for
precisely this kind of thing.
I want to keep the behavior of writebuffer being upgraded from nil to a
string to full buffer since the last step involves three table
allocations, where the previous buffer method only used one. Avoiding
those allocations for simple writes like white space keep alive feels
like it would keep memory churn down.
This work was started in 2020
|
| |
| |
| |
| |
| | |
Reduces duplication and need to edit in two places when adding another
metadata field.
|
| |
| |
| |
| |
| | |
No longer bypasses access control to retrieve this config subset, which
is also explicitly named in the service config now.
|
| |
| |
| |
| |
| |
| | |
Allows granting read only access to other sets of users using a separate
access control capability, which makes sense as some properties may be
intended to be public but read-only.
|
|\| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously the error messages said that it failed to "publish" to PEP, but
sometimes a sync involves removing items, which can be confusing.
The log was also the same for both legacy PEP and private XML bookmarks.
Having different log messages makes it easier to debug the cause and location
of any sync errors.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It appears that when:
1) The user has no bookmarks 2 node in PEP
2) The client publishes an empty bookmark set to a legacy bookmarks location
3) mod_bookmarks will attempt to purge items from the non-existent node and
log an error about the failure (item-not-found).
This new code will suppress an item-not-found error from the purge operation
in the empty-bookmarks case, and adds a log message for any other error (this
is helpful because the existing log message confusingly says it was an error
*publishing* to the node, which isn't always accurate).
|
| |
| |
| |
| | |
No, that wasn't running in a thread, but in a next tick timer.
|
|\| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prevents ASYNC-01 due to storage interactions in a timer.
Also considered modifying mod_c2s to allow passing arbitrary closures
into its runner thread but this seems like a big step away from the
current code for just this module.
Also considered creating a dedicated runner in mod_smacks, but ensuring
continuity across module reloads might be tricky.
We could further improve this in the next major version.
|
| |
| |
| |
| | |
The three-argument version seems to be a left-over from 0.12
|
| |
| |
| |
| |
| | |
Roles for JIDs outside the current host are derived from configuration
only with this module.
|
| |
| |
| |
| | |
mod_authz_internal does not support this
|
| |
| |
| |
| |
| | |
Seems exposing publisher is not enabled in mod_pep, but then it'll be
the user themselves most of the time
|
| |
| |
| |
| | |
This corresponds to the file mod_bookmarks2/tests/bookmarks2.scs
|
| |
| |
| |
| |
| |
| |
| | |
pkey_meth_derive: to derive a shared symmetric key from two ECC keys
pkey_meth_public_raw: to get the raw form of the public key
import_public_ec_raw: to import the raw form of the public key
generate_p256_keypair: key generation for the P-256 curve
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Removes dependency on util.error from util.pubsub which was only used
for this one special case.
Line count reduction!
Would be even nicer if templating could be done by util.error itself.
|
| |
| |
| |
| | |
Continuation of 4b39691a274e
|
| |
| |
| |
| | |
Sometimes it is useful to pass additional information along.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is what util.error was made for!
This replaces the custom error stanza builder with common code in
util.stanza that knows enough about util.error and namespaced errors.
Some awkwardness remains in the way util.pubsub returns conflicting
form fields.
|