| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
| |
Less to type if per chance the next commit also wants to access
sessions.
|
| |
|
|
|
|
| |
To ensure that if a session is replaced after it has gone into
hibernation, it does not come back and cause trouble for the new session
(see previous commit).
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The resumption_token is removed when the session is closed via the
pre-session-close event, signaling that it cannot be resumed, and
therefore no hibernation timeout logic should be invoked.
Fixes that if a session somehow is replaced by a new one using the same
resource (which is the common behavior), the old session would still be
around until it times out at which point it sends `<presence
type="unavailable"/>` which would look as if it came from the new
session, ie appearing offline to everyone including MUCs.
|
| |
|
|
| |
Meld keeps messing up indentation when I merge and rebase...
|
| |
|
|
|
|
|
|
|
|
| |
This overloads that flag a bit, but it has the intended effect of
stopping outgoing_stanza_filter() from queueing stanzas.
Fixes a traceback because of the queue having been removed somewhere
around here, since it is no longer needed.
Thanks Martin for reporting
|
| |
|
|
|
|
|
|
|
| |
This brings back the queue size limit that was once added, then removed
because destroying the session when reaching the limit was not great.
Instead, the queue wraps and overwrites the oldest unacked stanza on the
assumption that it will probably be acked anyway and thus does not need
to be delivered. If those discarded stanzas turn out to be needed on
resumption then the resumption fails.
|
| |
|
|
|
| |
Extending the timeout by poking the watchdog, and letting it go on
resumption, should be much better than the previous method.
|
| |
|
|
|
|
|
|
| |
All that was a complicated way to limit the number of resumable
sessions. Let's control resource usage some other way. This leaves the
essence of mapping resumption tokens to live sessions.
This keeps resumption state across reloads.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
This allows clients that try to resume a session after a server restart
to at least know which of their pending outgoing stanzas were received
and which need to be re-sent.
This removes the limit on how many of those counters are kept, which
should be fixed eventually.
|
| | |
|
| |
|
|
|
| |
Since nothing uses it. Some equivalent functionality may return in the
future.
|
| | |
|
| |
|
|
|
|
|
| |
I have no idea what is going on in this code, which session is which?
Something has one of the sessions as an upvalue which is where the
filter checks for it.
|
| |
|
|
|
| |
Encountered what looks like a bug where after *many* resumptions, part
of the queue was not acked.
|
| |
|
|
| |
Maybe it works now with the session patching in the previous commit
|
| |
|
|
|
| |
The number of places where the session is an upvalue to its own methods
is too high!
|
| |
|
|
|
|
|
|
| |
As per a86ae74da96c the 'session' object here is the wrong session, so
the attempt to block stanzas from being added to the queue twice did not
work causing something of a leak.
Instead we have a leak of the previous session.
|
| |
|
|
| |
The attempted fix completely broke everything after resumption.
|
| |
|
|
|
|
| |
a86ae74da96c caused the stanza queue to double on resumption because
session.send() keeps a reference to the session which is what gets
passed to filters, so the added flag was not seen in the filter.
|
| |
|
|
| |
To aid in debugging
|
| |
|
|
|
| |
Since reply.attr.to will be the .attr.from of the input we can check
this earlier and avoid constructing the reply at all.
|
| |
|
|
| |
Did error_reply() not exist when mod_smacks was first created?
|
| |
|
|
| |
It dates back to the initial commit in prosody-modules 9a7671720dec
|
| |
|
|
| |
Mutating the stanza like this is Really Bad Practice.
|
| |
|
|
|
| |
`cached_stanza` can't be falsy because util.stanza.clone() would have
thrown rather than return nil, or `._cached=true` would have.
|
| |
|
|
|
| |
Turns out that if you destroy a session from inside prosody, it goes
into hibernation but stays connected and continues processing stanzas.
|
| |
|
|
| |
Mostly sorted by name of import (sort -k4) and grouped by kind
|
| |
|
|
|
| |
In Lua, every value except `nil` and `false` are considered true in
boolean expressions, even `0` as here, which means this was dead code.
|
| |
|
|
|
| |
Non-stanza tables with an 'attr' field might be rare in Prosody, but
better to be Correct
|
| |
|
|
|
|
| |
Given that the registry is scoped per user and the module is scoped per
host, there seems no point to checking or storing both username and host
here.
|
| | |
|
| | |
|
| |
|
|
| |
Much cleaner.
|
| |
|
|
|
| |
Wrong level, missing argument, whatever it was meant to shed light on
has been resolved and forgotten.
|
| |
|
|
|
|
| |
Taking advantage of the new callbacks added in dcf38ac6a38c and
9c450185bac1 avoids extra timers, extra syscalls and sending the `<r>`
in its own TCP segment, improving efficiency.
|
| |
|
|
|
|
|
|
|
|
| |
The function was too large to comprehend! Breaking it up helps
readability and reuse.
The timer round rip is only to avoid ordering weirdness when sending
from inside a stanza filter. No need when handling <r> and <a>
CSI interactions both boiled down to sending an <r> immediately.
|
| |
|
|
|
|
|
| |
module:add_timer() creates a timer that stops working after the module
is reloaded or unloaded, in order to prevent leaks. However, when the
timers control vital session behavior, breakage occurs after reload.
E.g. sessions would stop requesting acks and stop responding to acks.
|
| |
|
|
|
|
|
|
| |
Unstoppable stoppable timer compat not needed since 26f54b462601 ca 0.11.0
module:hook_stanza was renamed in 2012
No idea what was going on with the indentation and such
|
| |
|
