| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
In Lua, every value except `nil` and `false` are considered true in
boolean expressions, even `0` as here, which means this was dead code.
|
|
|
|
|
| |
Non-stanza tables with an 'attr' field might be rare in Prosody, but
better to be Correct
|
|
|
|
|
|
| |
Given that the registry is scoped per user and the module is scoped per
host, there seems no point to checking or storing both username and host
here.
|
| |
|
| |
|
|
|
|
| |
Much cleaner.
|
|
|
|
|
|
| |
To allow modules to do things just before the session is closed. The
'(pre-)resource-unbind' events are fired after the stream is closed,
leaving no way to send something.
|
|
|
|
|
| |
This should skip the summary SQL query when not needed, ie when the
cached value can be used directly.
|
|
|
|
|
| |
Otherwise a query for a set of ids may cause that value to be cached,
despite only covering a subset.
|
|
|
|
|
|
|
| |
jid.join(true, ...) fails.
Since we don't know which users this affects, best to clear the whole
cache.
|
|
|
|
| |
More code, but less of it needs to run and no extra tracking is needed.
|
|
|
|
|
| |
archive_store:delete(true) deletes messages for all users, which would
allow some simplification when this is supported.
|
| |
|
| |
|
|
|
|
|
| |
Wrong level, missing argument, whatever it was meant to shed light on
has been resolved and forgotten.
|
|
|
|
| |
It was all of for some reason
|
|
|
|
| |
I've typed `>require"util.async".wait_for(...)` for the last time!
|
|
|
|
|
| |
'unavailable' was the longest possibility, dropping it probably
differentiates available from unavailable more, in less space.
|
|
|
|
| |
Tricky to represent "secure, but no details" in short enough space.
|
|
|
|
|
| |
Zash notes this seems to have been lost in 1b657605ea29, probably by
mistake.
|
|
|
|
| |
Thanks mod_http_openmetrics
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes GET /metrics work regardless of the value of the Host header.
This was not possible before 220468f7a103 which added the ability to
have global HTTP modules, which was partly why the per-host part was
kept while the module lived among the community modules.
Another reason was to provide some semblance of security by obscurity by
only loading the module on e.g. a 'localhost' VirtualHost or Component.
The new IP limits obsoletes this.
|
|
|
|
|
|
| |
Taking advantage of the new callbacks added in dcf38ac6a38c and
9c450185bac1 avoids extra timers, extra syscalls and sending the `<r>`
in its own TCP segment, improving efficiency.
|
|
|
|
|
|
|
|
|
|
| |
The function was too large to comprehend! Breaking it up helps
readability and reuse.
The timer round rip is only to avoid ordering weirdness when sending
from inside a stanza filter. No need when handling <r> and <a>
CSI interactions both boiled down to sending an <r> immediately.
|
|
|
|
|
|
|
| |
module:add_timer() creates a timer that stops working after the module
is reloaded or unloaded, in order to prevent leaks. However, when the
timers control vital session behavior, breakage occurs after reload.
E.g. sessions would stop requesting acks and stop responding to acks.
|
|
|
|
|
|
|
|
| |
Unstoppable stoppable timer compat not needed since 26f54b462601 ca 0.11.0
module:hook_stanza was renamed in 2012
No idea what was going on with the indentation and such
|
| |
|
|
|
|
|
|
|
|
| |
These are RECOMMENDED in XEP-0215 so most likely a mistake if they are
left out.
Of the two REQUIRED fields, 'host' falls back to module.host and 'type'
rejects the whole item.
|
|
|
|
| |
Marginal improvement in readability
|
|
|
|
| |
Lets you know what to look for with stats:show()
|
| |
|
|
|
|
|
|
|
|
|
| |
This version has several changes from the earlier mod_prometheus:
- Conversion of metrics into the text-based OpenMetrics format is moved to
util.openmetrics
- Support for IP-based access control
- Compatibility with earlier Prosody versions removed
|
|
|
|
|
|
| |
Both in the flushing and active states the right thing to do is skip
directly to returning the data. Also in any unknown state, like if the
filter is somehow left behind on module unload.
|
|
|
|
|
| |
Cuts down on log and measurement noise. We only want to do these things
here when initiating a flush.
|
|
|
|
|
|
|
|
|
|
| |
Statistics from my server shows a high rate of very short buffer hold
times, most of which are the result of replies to pings or other iq
traffic, or mod_smacks acks and ack requests just after a flush was
completed.
This grace period should eliminate noise and quick flipping between
flushing and inactive mode.
|
|
|
|
| |
Just adds noise
|
|
|
|
| |
So that the same things happen as when triggered by an outgoing stanza
|
|
|
|
| |
Not exactly the way it was before, but close enough and useful.
|
|
|
|
|
|
| |
Since it changes the state to "flushing" while doing just that.
Attempting to remove the filters from a session that does not have them
should be a safe noop.
|
| |
|
|
|
|
|
| |
Definitely should not be firing an event that triggers like csi-flushing
from which it may make sense to send things, which leads right back here
|
|
|
|
|
|
| |
E.g. mod_smacks could queue an <r>, which would be more likely to be
included in the same write and TCP segment as the previously buffered
data, reducing syscalls and network packets needing to be sent.
|
| |
|
| |
|
|
|
|
|
|
| |
.affiliation
It appears nothing currently uses this field in prosody or prosody-modules
|
| |
|
|
|
|
| |
...and fixing the logic bug that broke everything in the previous commit.
|
|
|
|
| |
data
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was originally not done based on my interpretation of XEP-0045. Today's
reading, however, revealed that it actually says the result
> SHOULD contain **at least** a <username/> element
(emphasis mine)
I take this to mean that including a form **is** allowed (and I think this is
sensible). Tigase already includes the form I believe.
I've gated the new behaviour behind a (default off) option, because it hasn't
been tested for compatibility with clients. My primary desire for it is in
Snikket, where the clients will be tested to ensure compatibility with this.
I don't anticipate that (m)any clients would break, so maybe after 0.12 we can
experiment with enabling it by default and eventually remove the option.
|
|
|
|
|
|
| |
arcseconds)
I surmise this can happen in a disconnected/smacks hibernation state.
|