From 1be4a5c2970e46671e1beeef502b702778c5562a Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 28 Mar 2021 13:51:06 +0200 Subject: mod_http_file_share: Fix reporting of missing files This just gave an unhelpful 500 error. It would be nice to have some wrapper code that could untangle the embedded filename in the io libs errors. --- plugins/mod_http_file_share.lua | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/plugins/mod_http_file_share.lua b/plugins/mod_http_file_share.lua index 2191cb30..f8ae05ae 100644 --- a/plugins/mod_http_file_share.lua +++ b/plugins/mod_http_file_share.lua @@ -339,9 +339,12 @@ function handle_download(event, path) -- GET /uploads/:slot+filename return 304; end local filename = get_filename(slot_id); - local handle, ferr = errors.coerce(io.open(filename)); + local handle, ferr = io.open(filename); if not handle then - return ferr or 410; + module:log("error", "Could not open file: %s", filename, ferr); + -- This can be because the upload slot wasn't used, or the file disappeared + -- somehow, or permission issues. + return 410; end if not filetype then -- cgit v1.2.3