From 29148cfe9ce0d6b60127ad158381acb90ca9ab53 Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Tue, 18 Jun 2024 15:08:30 +0100 Subject: MUC: Don't default component admins to being room owners This change has various technical and social benefits. If ownership of a MUC is really needed, it can be gained using the 'Set affiliation' ad-hoc command or prosodyctl shell. Example client incompatibility with the old behaviour: - https://github.com/monal-im/Monal/issues/1085 --- CHANGES | 4 ++++ plugins/muc/mod_muc.lua | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 4938f013..fbeec13c 100644 --- a/CHANGES +++ b/CHANGES @@ -16,6 +16,10 @@ TRUNK ### MUC +- Component admins are no longer room owners by default. This can be reverted + to the old behaviour with `component_admins_as_room_owners = true`, but this + has known incompatibilities with some clients. Instead, use the shell or + ad-hoc commands to gain ownership of rooms when necessary. - Permissions updates: - Room creation restricted to local users (of the parent host) by default - restrict_room_creation = true restricts to admins, false disables all restrictions diff --git a/plugins/muc/mod_muc.lua b/plugins/muc/mod_muc.lua index 7244ecbe..1dc99f07 100644 --- a/plugins/muc/mod_muc.lua +++ b/plugins/muc/mod_muc.lua @@ -125,7 +125,7 @@ module:default_permissions("prosody:guest", { ":list-rooms"; }); -if module:get_option_boolean("component_admins_as_room_owners", true) then +if module:get_option_boolean("component_admins_as_room_owners", false) then -- Monkey patch to make server admins room owners local _get_affiliation = room_mt.get_affiliation; function room_mt:get_affiliation(jid) -- cgit v1.2.3