From 4dcabd36ceaacc5534e93523e65e654f7f864379 Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Mon, 20 Feb 2023 18:10:15 +0000 Subject: mod_websocket: Fire pre-session-close event (fixes #1800) This event was added in a7c183bb4e64 and is required to make mod_smacks know that a session was intentionally closed and shouldn't be hibernated (see fcea4d9e7502). Because this was missing from mod_websocket's session.close(), mod_smacks would always attempt to hibernate websocket sessions even if they closed cleanly. That mod_websocket has its own copy of session.close() is something to fix another day (probably not in the stable branch). So for now this commit makes the minimal change to get things working again. Thanks to Damian and the Jitsi team for reporting. --- plugins/mod_websocket.lua | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/mod_websocket.lua b/plugins/mod_websocket.lua index bddcbb79..f0caa968 100644 --- a/plugins/mod_websocket.lua +++ b/plugins/mod_websocket.lua @@ -63,6 +63,9 @@ end local function session_close(session, reason) local log = session.log or log; + local close_event_payload = { session = session, reason = reason }; + module:context(session.host):fire_event("pre-session-close", close_event_payload); + reason = close_event_payload.reason; if session.conn then if session.notopen then session:open_stream(); -- cgit v1.2.3