From bd940f0f8cc76802ced47ed71c039186a225bc58 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 20 Nov 2016 11:15:10 +0100 Subject: util.envload: Ignore use of Lua 5.1-only setfenv function [luacheck] --- util/envload.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/util/envload.lua b/util/envload.lua index 53e28348..3c5190df 100644 --- a/util/envload.lua +++ b/util/envload.lua @@ -4,6 +4,7 @@ -- This project is MIT/X11 licensed. Please see the -- COPYING file in the source package for more information. -- +-- luacheck: ignore 113/setfenv local load, loadstring, loadfile, setfenv = load, loadstring, loadfile, setfenv; local envload; -- cgit v1.2.3 From 850f75497ad96223d58399257b94b0fa6db048ce Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 20 Nov 2016 11:30:26 +0100 Subject: prosody: Set session tables on the 'prosody' global first, then export them as globals --- prosody | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/prosody b/prosody index 9cc32cee..ad9b04cb 100755 --- a/prosody +++ b/prosody @@ -212,14 +212,14 @@ function set_function_metatable() end function init_global_state() - -- COMPAT: These globals are deprecated - bare_sessions = {}; - full_sessions = {}; - hosts = {}; + prosody.bare_sessions = {}; + prosody.full_sessions = {}; + prosody.hosts = {}; - prosody.bare_sessions = bare_sessions; - prosody.full_sessions = full_sessions; - prosody.hosts = hosts; + -- COMPAT: These globals are deprecated + bare_sessions = prosody.bare_sessions; + full_sessions = prosody.full_sessions; + hosts = prosody.hosts; local data_path = config.get("*", "data_path") or CFG_DATADIR or "data"; local custom_plugin_paths = config.get("*", "plugin_paths"); -- cgit v1.2.3 From 82da87e6299fe7820181dee35ce1b31ca15a6c4f Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 20 Nov 2016 11:32:05 +0100 Subject: prosody: Add annotations to ignore various globals and unused arguments [luacheck] --- prosody | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/prosody b/prosody index ad9b04cb..32aeba07 100755 --- a/prosody +++ b/prosody @@ -125,12 +125,17 @@ function check_dependencies() end end +-- luacheck: globals socket server + function load_libraries() -- Load socket framework socket = require "socket"; server = require "net.server" end +-- The global log() gets defined by loggingmanager +-- luacheck: ignore 113/log + function init_logging() -- Initialize logging require "core.loggingmanager" @@ -156,6 +161,7 @@ end function sandbox_require() -- Replace require() with one that doesn't pollute _G, required -- for neat sandboxing of modules + -- luacheck: ignore 113/getfenv 111/require local _realG = _G; local _real_require = require; local getfenv = getfenv or function (f) @@ -172,7 +178,7 @@ function sandbox_require() if curr_env_mt and curr_env_mt.__index and not curr_env_mt.__newindex and _realG_mt then local old_newindex, old_index; old_newindex, _realG_mt.__newindex = _realG_mt.__newindex, curr_env; - old_index, _realG_mt.__index = _realG_mt.__index, function (_G, k) + old_index, _realG_mt.__index = _realG_mt.__index, function (_G, k) -- luacheck: ignore 212/_G return rawget(curr_env, k); end; local ret = _real_require(...); @@ -217,6 +223,7 @@ function init_global_state() prosody.hosts = {}; -- COMPAT: These globals are deprecated + -- luacheck: ignore 111/bare_sessions 111/full_sessions 111/hosts bare_sessions = prosody.bare_sessions; full_sessions = prosody.full_sessions; hosts = prosody.hosts; @@ -349,6 +356,7 @@ end function init_global_protection() -- Catch global accesses + -- luacheck: ignore 212/t local locked_globals_mt = { __index = function (t, k) log("warn", "%s", debug.traceback("Attempt to read a non-existent global '"..tostring(k).."'", 2)); end; __newindex = function (t, k, v) error("Attempt to set a global: "..tostring(k).." = "..tostring(v), 2); end; -- cgit v1.2.3 From fdf2a552ce5930cb72bdf8e302637b68359f2df3 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 20 Nov 2016 11:51:13 +0100 Subject: mod_posix: Use type-specific config API --- plugins/mod_posix.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/mod_posix.lua b/plugins/mod_posix.lua index 7e6d8799..0a6845ac 100644 --- a/plugins/mod_posix.lua +++ b/plugins/mod_posix.lua @@ -26,7 +26,7 @@ local prosody = _G.prosody; module:set_global(); -- we're a global module -local umask = module:get_option("umask") or "027"; +local umask = module:get_option_string("umask", "027"); pposix.umask(umask); -- Allow switching away from root, some people like strange ports. -- cgit v1.2.3 From e3ab638262a338df9f31b351a47c430f9e067832 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 20 Nov 2016 12:03:24 +0100 Subject: util.datamanager: Use the 'base' argument to tonumber() to indicate hexadecimal --- util/datamanager.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/datamanager.lua b/util/datamanager.lua index 2884b942..148605d9 100644 --- a/util/datamanager.lua +++ b/util/datamanager.lua @@ -50,7 +50,7 @@ local _ENV = nil; ---- utils ----- local encode, decode; do - local urlcodes = setmetatable({}, { __index = function (t, k) t[k] = char(tonumber("0x"..k)); return t[k]; end }); + local urlcodes = setmetatable({}, { __index = function (t, k) t[k] = char(tonumber(k, 16)); return t[k]; end }); decode = function (s) return s and (s:gsub("+", " "):gsub("%%([a-fA-F0-9][a-fA-F0-9])", urlcodes)); -- cgit v1.2.3 From f0bd3ec40322b46444b6d944fce24e5beaaf0bf4 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 20 Nov 2016 12:05:43 +0100 Subject: util.datamanager: Remove extraneous decoding of + to space, which we never never encode to --- util/datamanager.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/datamanager.lua b/util/datamanager.lua index 148605d9..ddc71899 100644 --- a/util/datamanager.lua +++ b/util/datamanager.lua @@ -53,7 +53,7 @@ do local urlcodes = setmetatable({}, { __index = function (t, k) t[k] = char(tonumber(k, 16)); return t[k]; end }); decode = function (s) - return s and (s:gsub("+", " "):gsub("%%([a-fA-F0-9][a-fA-F0-9])", urlcodes)); + return s and (s:gsub("%%([a-fA-F0-9][a-fA-F0-9])", urlcodes)); end encode = function (s) -- cgit v1.2.3 From f36fed39e8110ee3c36e0587811ce3268ae6690e Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 20 Nov 2016 12:06:36 +0100 Subject: util.datamanager: Shorter pattern --- util/datamanager.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/datamanager.lua b/util/datamanager.lua index ddc71899..585bb83d 100644 --- a/util/datamanager.lua +++ b/util/datamanager.lua @@ -53,7 +53,7 @@ do local urlcodes = setmetatable({}, { __index = function (t, k) t[k] = char(tonumber(k, 16)); return t[k]; end }); decode = function (s) - return s and (s:gsub("%%([a-fA-F0-9][a-fA-F0-9])", urlcodes)); + return s and (s:gsub("%%(%x%x)", urlcodes)); end encode = function (s) -- cgit v1.2.3