From 710339a8384dac99e332d05fcadbd87a4f2197b8 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Fri, 3 Apr 2020 22:35:47 +0200 Subject: mod_vcard4: Report correct error condition (fixes #1521) On error, the second return value is the error condition, not the third. --- plugins/mod_vcard4.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/mod_vcard4.lua b/plugins/mod_vcard4.lua index 378c0602..04dbca9e 100644 --- a/plugins/mod_vcard4.lua +++ b/plugins/mod_vcard4.lua @@ -14,9 +14,9 @@ module:hook("iq-get/bare/urn:ietf:params:xml:ns:vcard-4.0:vcard", function (even local ok, id, item = pep_service:get_last_item("urn:xmpp:vcard4", stanza.attr.from); if ok and item then origin.send(st.reply(stanza):add_child(item.tags[1])); - elseif item == "item-not-found" or not id then + elseif id == "item-not-found" or not id then origin.send(st.error_reply(stanza, "cancel", "item-not-found")); - elseif item == "forbidden" then + elseif id == "forbidden" then origin.send(st.error_reply(stanza, "auth", "forbidden")); else origin.send(st.error_reply(stanza, "modify", "undefined-condition")); -- cgit v1.2.3