From 9e8e910f1e7be52db27ec26aeb9f39171a6946b5 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Wed, 20 Apr 2022 22:41:54 +0200 Subject: net.connect: Fix accumulation of connection attempt references Connection attempts that failed the Happy Eyeballs race were not unreferenced and would accumulate. Tested by inspecting the 'pending_connections_map' after establishing s2s with a s2s target where the IPv6 port has a -j DROP rule causing it to time out and the IPv4 attempt wins the race. Expected is that the losing connection stays around until net.server timeouts kick in where it should be removed. The map table should tend towards being empty during idle times. --- net/connect.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/net/connect.lua b/net/connect.lua index f2c932f9..d85afcff 100644 --- a/net/connect.lua +++ b/net/connect.lua @@ -91,6 +91,7 @@ function pending_connection_listeners.ondisconnect(conn, reason) return; end p.conns[conn] = nil; + pending_connections_map[conn] = nil; p.last_error = reason or "unknown reason"; p:log("debug", "Connection attempt failed: %s", p.last_error); if p.connected then -- cgit v1.2.3