From bbfe15dac5b144d69f3fcd6c3254f664eb3adf7e Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Wed, 24 Nov 2021 21:27:49 +0100 Subject: mod_smacks: Optimize scheduling of ack requests Taking advantage of the new callbacks added in dcf38ac6a38c and 9c450185bac1 avoids extra timers, extra syscalls and sending the `` in its own TCP segment, improving efficiency. --- plugins/mod_smacks.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/mod_smacks.lua b/plugins/mod_smacks.lua index 54da11b6..2387c0f4 100644 --- a/plugins/mod_smacks.lua +++ b/plugins/mod_smacks.lua @@ -236,7 +236,6 @@ local function outgoing_stanza_filter(stanza, session) module:fire_event("smacks-hibernation-stanza-queued", {origin = session, queue = queue, stanza = cached_stanza}); return nil; end - request_ack_if_needed(session, false, "outgoing_stanza_filter", stanza); end return stanza; end @@ -652,6 +651,8 @@ module:hook_tag(xmlns_sm3, "resume", function (session, stanza) return handle_re local request_ack_events = { ["csi-client-active"] = true; ["csi-flushing"] = false; + ["c2s-pre-ondrain"] = false; + ["s2s-pre-ondrain"] = false; }; for event_name, force in pairs(request_ack_events) do -- cgit v1.2.3