From dbf1692a4550b077bed5d609d08d0f1678fc8a72 Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Wed, 4 Apr 2018 18:27:44 +0100 Subject: net.http: Fix parameter order to http request callbacks Commit e3b9dc9dd940 changed the parameter order in 2013, but did not update the names of the parameters in the callback function. Due to this inconsistency, 12df41a5a4b1 accidentally reversed the order when fixing the variable names without fixing where they are used. Additionally the documentation was incorrect (since 2013), and this has also now been fixed. --- net/http.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/http.lua b/net/http.lua index 8364a104..cc67a45c 100644 --- a/net/http.lua +++ b/net/http.lua @@ -238,7 +238,7 @@ local function request(self, u, ex, callback) end log("debug", "Request '%s': Calling callback, status %s", req.id, code or "---"); - return log_if_failed(req.id, xpcall(function () return callback(content, code, request, response) end, handleerr)); + return log_if_failed(req.id, xpcall(function () return callback(content, code, response, request) end, handleerr)); end req.reader = request_reader; req.state = "status"; -- cgit v1.2.3