From de9cac43cccfd45ad867c7f08013860d0a0ea217 Mon Sep 17 00:00:00 2001 From: Waqas Hussain Date: Fri, 2 Oct 2009 16:50:30 +0500 Subject: mod_register: Fixed: No error was returned if username failed nodeprep. --- plugins/mod_register.lua | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/plugins/mod_register.lua b/plugins/mod_register.lua index 383ab811..d29a74af 100644 --- a/plugins/mod_register.lua +++ b/plugins/mod_register.lua @@ -140,14 +140,17 @@ module:add_iq_handler("c2s_unauthed", "jabber:iq:register", function (session, s -- FIXME shouldn't use table.concat username = nodeprep(table.concat(username)); password = table.concat(password); - if usermanager_user_exists(username, session.host) then + local host = module.host; + if not username then + session.send(st.error_reply(stanza, "modify", "not-acceptable")); + elseif usermanager_user_exists(username, host) then session.send(st.error_reply(stanza, "cancel", "conflict")); else - if usermanager_create_user(username, password, session.host) then + if usermanager_create_user(username, password, host) then session.send(st.reply(stanza)); -- user created! - module:log("info", "User account created: %s@%s", username, session.host); + module:log("info", "User account created: %s@%s", username, host); module:fire_event("user-registered", { - username = username, host = session.host, source = "mod_register", + username = username, host = host, source = "mod_register", session = session }); else -- TODO unable to write file, file may be locked, etc, what's the correct error? -- cgit v1.2.3