From f814af50e3e7a024d8434219110c9c680ac2fb97 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 11 Jul 2021 09:39:21 +0200 Subject: net.server_epoll: Prevent stack overflow of opportunistic writes net.http.files serving a big enough file on a fast enough connection with opportunistic_writes enabled could trigger a stack overflow through repeatedly serving more data that immediately gets sent, draining the buffer and triggering more data to be sent. This also blocked the server on a single task until completion or an error. This change prevents nested opportunistic writes, which should prevent the stack overflow, at the cost of reduced download speed, but this is unlikely to be noticeable outside of Gbit networks. Speed at the cost of blocking other processing is not worth it, especially with the risk of stack overflow. --- net/server_epoll.lua | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/server_epoll.lua b/net/server_epoll.lua index d2a1759b..f93809b4 100644 --- a/net/server_epoll.lua +++ b/net/server_epoll.lua @@ -499,8 +499,10 @@ function interface:write(data) self.writebuffer = { data }; end if not self._write_lock then - if cfg.opportunistic_writes then + if cfg.opportunistic_writes and not self._opportunistic_write then + self._opportunistic_write = true; self:onwritable(); + self._opportunistic_write = nil; return #data; end self:setwritetimeout(); -- cgit v1.2.3