From fd5a0f6a063677e35863589ad6980e1178d38746 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 6 Feb 2022 14:34:02 +0100 Subject: mod_admin_shell: Track connected events instead of created The connection events are more appropriate here, where the s2s-created events happens a bit later or earlier in a sessions lifetime depending on its direction and for outgoing connections isn't actually the creation time (which happens immediately after pressing enter, so not very interesting), but rather closer to the connection time. --- plugins/mod_admin_shell.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/mod_admin_shell.lua b/plugins/mod_admin_shell.lua index 13ab213f..a8da5c09 100644 --- a/plugins/mod_admin_shell.lua +++ b/plugins/mod_admin_shell.lua @@ -1482,17 +1482,17 @@ function def_env.xmpp:ping(localhost, remotehost, timeout) end end end - local oncreated = onchange("created"); + local onconnected = onchange("connected"); local onauthenticated = onchange("authenticated"); local onestablished = onchange("established"); local ondestroyed = onchange("destroyed"); - module:hook("s2s-created", oncreated, 1); + module:hook("s2s-connected", onconnected, 1); module:context(localhost):hook("s2s-authenticated", onauthenticated, 1); module:hook("s2sout-established", onestablished, 1); module:hook("s2sin-established", onestablished, 1); module:hook("s2s-destroyed", ondestroyed, 1); return module:context(localhost):send_iq(iq, nil, timeout):finally(function() - module:unhook("s2s-created", oncreated); + module:unhook("s2s-connected", onconnected, 1); module:context(localhost):unhook("s2s-authenticated", onauthenticated); module:unhook("s2sout-established", onestablished); module:unhook("s2sin-established", onestablished); -- cgit v1.2.3