From 0f9fd252f66c66629d1e59720750a972e5945cf5 Mon Sep 17 00:00:00 2001 From: Waqas Hussain Date: Mon, 30 Mar 2009 01:57:51 +0500 Subject: Fixed: stanza_router: Respond with correct stanza error on malformed stanzas --- core/stanza_router.lua | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'core/stanza_router.lua') diff --git a/core/stanza_router.lua b/core/stanza_router.lua index ef973ba2..bbbb6385 100644 --- a/core/stanza_router.lua +++ b/core/stanza_router.lua @@ -51,9 +51,11 @@ function core_process_stanza(origin, stanza) if not stanza.attr.xmlns then stanza.attr.xmlns = "jabber:client"; end -- FIXME Hack. This should be removed when we fix namespace handling. -- TODO verify validity of stanza (as well as JID validity) - if stanza.name == "iq" and #stanza.tags > 1 then - if stanza.attr.type == "set" or stanza.attr.type == "get" then - error("Invalid IQ"); + if stanza.attr.xmlns == "error" and #stanza.tags == 0 then return; end -- TODO invalid stanza, log + if stanza.name == "iq" then + if (stanza.attr.type == "set" or stanza.attr.type == "get") and #stanza.tags ~= 1 then + origin.send(st.error_reply(stanza, "modify", "bad-request")); + return; end end -- cgit v1.2.3