From ceb93e38fe12ed768f8f114e064b145bccacd62a Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Tue, 28 Jul 2009 15:03:42 +0100 Subject: core.loggingmanager: Enable timestamps by default for file log sinks --- core/loggingmanager.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core') diff --git a/core/loggingmanager.lua b/core/loggingmanager.lua index 1d2f8d7d..d701511e 100644 --- a/core/loggingmanager.lua +++ b/core/loggingmanager.lua @@ -222,7 +222,7 @@ function log_sink_types.file(config) local timestamps = config.timestamps; - if timestamps == true then + if timestamps == nil or timestamps == true then timestamps = default_timestamp; -- Default format end -- cgit v1.2.3 From 08391171c3d3f104cd1bc7e855936b04870e81e1 Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Tue, 28 Jul 2009 17:43:46 +0100 Subject: hostmanager: Warn when user puts port configuration under vhost section --- core/hostmanager.lua | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'core') diff --git a/core/hostmanager.lua b/core/hostmanager.lua index c7b975d1..ba363273 100644 --- a/core/hostmanager.lua +++ b/core/hostmanager.lua @@ -41,6 +41,11 @@ function activate(host, host_config) or (configmanager.get(host, "core", "anonymous_login") and (configmanager.get(host, "core", "disallow_s2s") ~= false)) }; + for option_name in pairs(host_config.core) do + if option_name:match("_ports$") then + log("warn", "%s: Option '%s' has no effect for virtual hosts - put it in global Host \"*\" instead", host, option_name); + end + end log((hosts_loaded_once and "info") or "debug", "Activated host: %s", host); eventmanager.fire_event("host-activated", host, host_config); end -- cgit v1.2.3 From 57f4a5c837c5039eee6edd83d9516bca9a82c9d0 Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Tue, 28 Jul 2009 18:02:11 +0100 Subject: configmanager: Default options appearing before Host "*" to global (fixes potential traceback) --- core/configmanager.lua | 1 + 1 file changed, 1 insertion(+) (limited to 'core') diff --git a/core/configmanager.lua b/core/configmanager.lua index 7fc6aa13..b7ee605f 100644 --- a/core/configmanager.lua +++ b/core/configmanager.lua @@ -113,6 +113,7 @@ do set(env.__currenthost or "*", "core", k, v); end}); + rawset(env, "__currenthost", "*") -- Default is global function env.Host(name) rawset(env, "__currenthost", name); -- Needs at least one setting to logically exist :) -- cgit v1.2.3