From 93121127fa4ed579516ab203c3e2696725551d37 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Fri, 12 Nov 2021 16:52:55 +0100 Subject: net.connect: Propagate last error message from resolvers Previously it would only say "unable to resolve server" for all DNS problems. While "NoError in A lookup" might not make much sense to users, it should help in debugging more than the previous generic error. Friendlier errors will be future work. --- net/connect.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'net/connect.lua') diff --git a/net/connect.lua b/net/connect.lua index d52d3901..51c36c7b 100644 --- a/net/connect.lua +++ b/net/connect.lua @@ -35,9 +35,9 @@ local function attempt_connection(p) p.target_resolver:next(function (conn_type, ip, port, extra) if not conn_type then -- No more targets to try - p:log("debug", "No more connection targets to try"); + p:log("debug", "No more connection targets to try", p.target_resolver.last_error); if p.listeners.onfail then - p.listeners.onfail(p.data, p.last_error or "unable to resolve service"); + p.listeners.onfail(p.data, p.target_resolver.last_error or p.last_error or "unable to resolve service"); end return; end -- cgit v1.2.3