From 9ebd0d448763c18de04a39a8aa52521620659eca Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sun, 29 Jul 2018 18:34:38 +0200 Subject: mod_pep_plus: Fix boolean logic precedence (thanks Link Mauve) In case of 'from' subscription to a JID without node, eg a component, the condition becomes true and update_subscriptions() is called with contact_node = nil, which causes a traceback. --- plugins/mod_pep_plus.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugins/mod_pep_plus.lua') diff --git a/plugins/mod_pep_plus.lua b/plugins/mod_pep_plus.lua index cccabf6f..89c1f820 100644 --- a/plugins/mod_pep_plus.lua +++ b/plugins/mod_pep_plus.lua @@ -423,7 +423,7 @@ module:hook("iq-result/bare/disco", function(event) for jid, item in pairs(origin.roster) do -- for all interested contacts if jid then local contact_node, contact_host = jid_split(jid); - if contact_host == host and item.subscription == "both" or item.subscription == "from" then + if contact_host == host and (item.subscription == "both" or item.subscription == "from") then update_subscriptions(user_bare, contact_node, notify); end end -- cgit v1.2.3