From a608cc50da05ada72b0eef29ed8112f94b5c2ba2 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Wed, 2 Nov 2016 13:08:12 +0100 Subject: mod_register: Additional logging for various registration failure cases --- plugins/mod_register.lua | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'plugins/mod_register.lua') diff --git a/plugins/mod_register.lua b/plugins/mod_register.lua index df833cad..8929529e 100644 --- a/plugins/mod_register.lua +++ b/plugins/mod_register.lua @@ -204,6 +204,7 @@ module:hook("stanza/iq/jabber:iq:register:query", function(event) local log = session.log or module._log; if not(allow_registration) or session.type ~= "c2s_unauthed" then + log("debug", "Attempted registration when disabled or already authenticated"); session.send(st.error_reply(stanza, "cancel", "service-unavailable")); else local query = stanza.tags[1]; @@ -217,6 +218,10 @@ module:hook("stanza/iq/jabber:iq:register:query", function(event) else local data, errors = parse_response(query); if errors then + log("debug", "Error parsing registration form:"); + for field, err in pairs(errors) do + log("debug", "Field %q: %s", field, err); + end session.send(st.error_reply(stanza, "modify", "not-acceptable")); else -- Check that the user is not blacklisted or registering too often @@ -227,6 +232,7 @@ module:hook("stanza/iq/jabber:iq:register:query", function(event) return true; elseif min_seconds_between_registrations and not whitelisted_ips[session.ip] then if not check_throttle(session.ip) then + log("debug", "Registrations over limit for ip %s", session.ip or "?"); session.send(st.error_reply(stanza, "wait", "not-acceptable")); return true; end @@ -235,20 +241,24 @@ module:hook("stanza/iq/jabber:iq:register:query", function(event) data.username, data.password = nil, nil; local host = module.host; if not username or username == "" then + log("debug", "The requested username is invalid."); session.send(st.error_reply(stanza, "modify", "not-acceptable", "The requested username is invalid.")); return true; end local user = { username = username , host = host, allowed = true } module:fire_event("user-registering", user); if not user.allowed then + log("debug", "Registration disallowed by module"); session.send(st.error_reply(stanza, "modify", "not-acceptable", "The requested username is forbidden.")); elseif usermanager_user_exists(username, host) then + log("debug", "Attempt to register with existing username"); session.send(st.error_reply(stanza, "cancel", "conflict", "The requested username already exists.")); else -- TODO unable to write file, file may be locked, etc, what's the correct error? local error_reply = st.error_reply(stanza, "wait", "internal-server-error", "Failed to write data to disk."); if usermanager_create_user(username, password, host) then if next(data) and not account_details:set(username, data) then + log("debug", "Could not store extra details"); usermanager_delete_user(username, host); session.send(error_reply); return true; @@ -259,6 +269,7 @@ module:hook("stanza/iq/jabber:iq:register:query", function(event) username = username, host = host, source = "mod_register", session = session }); else + log("debug", "Could not create user"); session.send(error_reply); end end -- cgit v1.2.3 From 90569190248a26e3de853703b28855e69e43e251 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Wed, 2 Nov 2016 13:30:45 +0100 Subject: mod_register: Use throttle_max as indicator of limits being enabled, in case min_seconds_between_registrations is not used --- plugins/mod_register.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugins/mod_register.lua') diff --git a/plugins/mod_register.lua b/plugins/mod_register.lua index 8929529e..12d3c232 100644 --- a/plugins/mod_register.lua +++ b/plugins/mod_register.lua @@ -230,7 +230,7 @@ module:hook("stanza/iq/jabber:iq:register:query", function(event) elseif blacklisted_ips[session.ip] or (whitelist_only and not whitelisted_ips[session.ip]) then session.send(st.error_reply(stanza, "cancel", "not-acceptable", "You are not allowed to register an account.")); return true; - elseif min_seconds_between_registrations and not whitelisted_ips[session.ip] then + elseif throttle_max and not whitelisted_ips[session.ip] then if not check_throttle(session.ip) then log("debug", "Registrations over limit for ip %s", session.ip or "?"); session.send(st.error_reply(stanza, "wait", "not-acceptable")); -- cgit v1.2.3 From eabed1919953d167f353586c3cef16ad9c891fb0 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Wed, 2 Nov 2016 13:34:09 +0100 Subject: mod_register: Rename session reference in wrapped close method [luacheck] --- plugins/mod_register.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'plugins/mod_register.lua') diff --git a/plugins/mod_register.lua b/plugins/mod_register.lua index 12d3c232..eaa0614d 100644 --- a/plugins/mod_register.lua +++ b/plugins/mod_register.lua @@ -101,9 +101,9 @@ local function handle_registration_stanza(event) -- This one weird trick sends a reply to this stanza before the user is deleted local old_session_close = session.close; - session.close = function(session, ...) - session.send(st.reply(stanza)); - return old_session_close(session, ...); + session.close = function(self, ...) + self.send(st.reply(stanza)); + return old_session_close(self, ...); end local ok, err = usermanager_delete_user(username, host); -- cgit v1.2.3