From e76bc541aa96c70ddb4f814f394111b653fa026b Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Tue, 26 May 2009 01:27:07 +0100 Subject: mod_roster: Add some comments for the error cases to improve readability --- plugins/mod_roster.lua | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'plugins/mod_roster.lua') diff --git a/plugins/mod_roster.lua b/plugins/mod_roster.lua index 13ba8c99..bdc9a233 100644 --- a/plugins/mod_roster.lua +++ b/plugins/mod_roster.lua @@ -114,19 +114,25 @@ module:add_iq_handler("c2s", "jabber:iq:roster", end local success, err_type, err_cond, err_msg = rm_add_to_roster(session, jid, r_item); if success then + -- Ok, send success session.send(st.reply(stanza)); + -- and push change to all resources rm_roster_push(from_node, from_host, jid); else + -- Adding to roster failed session.send(st.error_reply(stanza, err_type, err_cond, err_msg)); end end else + -- Trying to add self to roster session.send(st.error_reply(stanza, "cancel", "not-allowed")); end else + -- Invalid JID added to roster session.send(st.error_reply(stanza, "modify", "bad-request")); -- FIXME what's the correct error? end else + -- Roster set didn't include a single item, or its name wasn't 'item' session.send(st.error_reply(stanza, "modify", "bad-request")); end return true; -- cgit v1.2.3