From bbff39858de6bb4c7c2714c658856e9d7b32dd6f Mon Sep 17 00:00:00 2001 From: Waqas Hussain Date: Sun, 12 Oct 2008 17:41:14 +0500 Subject: Fixed: mod_roster now outputs all roster data (instead of just the JIDs) --- plugins/mod_roster.lua | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'plugins/mod_roster.lua') diff --git a/plugins/mod_roster.lua b/plugins/mod_roster.lua index 962c6c70..6d981761 100644 --- a/plugins/mod_roster.lua +++ b/plugins/mod_roster.lua @@ -8,7 +8,15 @@ add_iq_handler("c2s", "jabber:iq:roster", local roster = st.reply(stanza) :query("jabber:iq:roster"); for jid in pairs(session.roster) do - roster:tag("item", { jid = jid, subscription = "none" }):up(); + local item = st.stanza("item", { + jid = jid, + subscription = session.roster[jid].subscription, + name = session.roster[jid].name, + }); + for group in pairs(session.roster[jid].groups) do + item:tag("group"):text(group):up(); + end + roster:add_child(item); end send(session, roster); return true; -- cgit v1.2.3 From 7f7444f62b5c40d2ee9e1e4b10c9ccf0112f7fe6 Mon Sep 17 00:00:00 2001 From: Waqas Hussain Date: Fri, 17 Oct 2008 22:20:03 +0500 Subject: Added: More complete implementation for mod_roster --- plugins/mod_roster.lua | 91 ++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 77 insertions(+), 14 deletions(-) (limited to 'plugins/mod_roster.lua') diff --git a/plugins/mod_roster.lua b/plugins/mod_roster.lua index 6d981761..f32efaa8 100644 --- a/plugins/mod_roster.lua +++ b/plugins/mod_roster.lua @@ -2,23 +2,86 @@ local st = require "util.stanza" local send = require "core.sessionmanager".send_to_session +local jid_split = require "util.jid".split; +local t_concat = table.concat; + +local rm_remove_from_roster = require "core.rostermanager".remove_from_roster; +local rm_roster_push = require "core.rostermanager".roster_push; + add_iq_handler("c2s", "jabber:iq:roster", function (session, stanza) - if stanza.attr.type == "get" then - local roster = st.reply(stanza) - :query("jabber:iq:roster"); - for jid in pairs(session.roster) do - local item = st.stanza("item", { - jid = jid, - subscription = session.roster[jid].subscription, - name = session.roster[jid].name, - }); - for group in pairs(session.roster[jid].groups) do - item:tag("group"):text(group):up(); + if stanza.tags[1].name == "query" then + if stanza.attr.type == "get" then + local roster = st.reply(stanza) + :query("jabber:iq:roster"); + for jid in pairs(session.roster) do + local item = st.stanza("item", { + jid = jid, + subscription = session.roster[jid].subscription, + name = session.roster[jid].name, + }); + for group in pairs(session.roster[jid].groups) do + item:tag("group"):text(group):up(); + end + roster:add_child(item); + end + send(session, roster); + return true; + elseif stanza.attr.type == "set" then + local query = stanza.tags[1]; + if #query.tags == 1 and query.tags[1].name == "item" + and query.tags[1].attr.xmlns == "jabber:iq:roster" and query.tags[1].attr.jid then + local item = query.tags[1]; + local from_node, from_host = jid_split(stanza.attr.from); + local node, host, resource = jid_split(item.attr.jid); + if not resource then + if item.attr.jid ~= from_node.."@"..from_host then + if item.attr.subscription == "remove" then + if session.roster[item.attr.jid] then + local success, err_type, err_cond, err_msg = rm_remove_from_roster(session, item.attr.jid); + if success then + send(session, st.reply(stanza)); + rm_roster_push(from_node, from_host, item.attr.jid); + else + send(session, st.error_reply(stanza, err_type, err_cond, err_msg)); + end + else + send(session, st.error_reply(stanza, "modify", "item-not-found")); + end + else + local r_item = {name = item.attr.name, groups = {}}; + if r_item.name == "" then r_item.name = nil; end + if session.roster[item.attr.jid] then + r_item.subscription = session.roster[item.attr.jid]; + else + r_item.subscription = "none"; + end + for _, child in ipairs(item) do + if child.name == "group" then + local text = t_concat(child); + if text and text ~= "" then + r_item.groups[text] = true; + end + end + end + local success, err_type, err_cond, err_msg = rm_add_to_roster(session, item.attr.jid, r_item); + if success then + send(session, st.reply(stanza)); + rm_roster_push(from_node, from_host, item.attr.jid); + else + send(session, st.error_reply(stanza, err_type, err_cond, err_msg)); + end + end + else + send(session, st.error_reply(stanza, "cancel", "not-allowed")); + end + else + send(session, st.error_reply(stanza, "modify", "bad-request")); -- FIXME what's the correct error? + end + else + send(session, st.error_reply(stanza, "modify", "bad-request")); end - roster:add_child(item); + return true; end - send(session, roster); - return true; end end); \ No newline at end of file -- cgit v1.2.3 From 9595202d474b7c2dd6654603cc81818b53682e87 Mon Sep 17 00:00:00 2001 From: Waqas Hussain Date: Wed, 22 Oct 2008 21:20:07 +0500 Subject: Fixed: Roster support --- plugins/mod_roster.lua | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'plugins/mod_roster.lua') diff --git a/plugins/mod_roster.lua b/plugins/mod_roster.lua index f32efaa8..8e2f6bbb 100644 --- a/plugins/mod_roster.lua +++ b/plugins/mod_roster.lua @@ -6,6 +6,7 @@ local jid_split = require "util.jid".split; local t_concat = table.concat; local rm_remove_from_roster = require "core.rostermanager".remove_from_roster; +local rm_add_to_roster = require "core.rostermanager".add_to_roster; local rm_roster_push = require "core.rostermanager".roster_push; add_iq_handler("c2s", "jabber:iq:roster", @@ -15,15 +16,14 @@ add_iq_handler("c2s", "jabber:iq:roster", local roster = st.reply(stanza) :query("jabber:iq:roster"); for jid in pairs(session.roster) do - local item = st.stanza("item", { + roster:tag("item", { jid = jid, subscription = session.roster[jid].subscription, name = session.roster[jid].name, }); for group in pairs(session.roster[jid].groups) do - item:tag("group"):text(group):up(); + roster:tag("group"):text(group):up(); end - roster:add_child(item); end send(session, roster); return true; @@ -52,7 +52,7 @@ add_iq_handler("c2s", "jabber:iq:roster", local r_item = {name = item.attr.name, groups = {}}; if r_item.name == "" then r_item.name = nil; end if session.roster[item.attr.jid] then - r_item.subscription = session.roster[item.attr.jid]; + r_item.subscription = session.roster[item.attr.jid].subscription; else r_item.subscription = "none"; end -- cgit v1.2.3 From 6701f399ad2e7aa07683d5612dd7e32635fdcee3 Mon Sep 17 00:00:00 2001 From: Waqas Hussain Date: Thu, 23 Oct 2008 02:11:27 +0500 Subject: Added session property for interested resources --- plugins/mod_roster.lua | 1 + 1 file changed, 1 insertion(+) (limited to 'plugins/mod_roster.lua') diff --git a/plugins/mod_roster.lua b/plugins/mod_roster.lua index 8e2f6bbb..8a20f76d 100644 --- a/plugins/mod_roster.lua +++ b/plugins/mod_roster.lua @@ -26,6 +26,7 @@ add_iq_handler("c2s", "jabber:iq:roster", end end send(session, roster); + session.interested = true; -- resource is interested in roster updates return true; elseif stanza.attr.type == "set" then local query = stanza.tags[1]; -- cgit v1.2.3