From 27d8902b8e38dd459f0b69dc9f17ebf6ad3e2059 Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Thu, 13 Sep 2018 16:35:48 +0100 Subject: util.stanza: Don't automatically generate ids for iq stanzas Users of this API should provide their own id attribute that meets their uniqueness requirements. The current implementation leaks information (i.e. how many iq stanzas have been sent by the server to other JIDs). Providing any strong guarantees of randomness here would need to pull in additional dependencies that we don't want in this simple library. --- spec/util_stanza_spec.lua | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'spec') diff --git a/spec/util_stanza_spec.lua b/spec/util_stanza_spec.lua index 4263923d..dcbd6cf8 100644 --- a/spec/util_stanza_spec.lua +++ b/spec/util_stanza_spec.lua @@ -84,9 +84,20 @@ describe("util.stanza", function() end); describe("#iq()", function() - it("should work", function() - local i = st.iq(); - assert.are.equal(i.name, "iq"); + it("should create an iq stanza", function() + local i = st.iq({ id = "foo" }); + assert.are.equal("iq", i.name); + assert.are.equal("foo", i.attr.id); + end); + + it("should reject stanzas with no id", function () + assert.has.error_match(function () + local i = st.iq(); + end, "id attribute"); + + assert.has.error_match(function () + local i = st.iq({ foo = "bar" }); + end, "id attribute"); end); end); -- cgit v1.2.3