From cced954ac3e55bff2dabb86c555044eb007e44d4 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Sat, 15 Jan 2022 16:25:25 +0100 Subject: util.jid: Explicitly check for nil rather than falsy A boolean false should blow up. --- spec/util_jid_spec.lua | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'spec') diff --git a/spec/util_jid_spec.lua b/spec/util_jid_spec.lua index 17cadbee..b92ca06c 100644 --- a/spec/util_jid_spec.lua +++ b/spec/util_jid_spec.lua @@ -13,6 +13,11 @@ describe("util.jid", function() assert.are.equal(jid.join(nil, nil, "c"), nil, "invalid JID is nil"); assert.are.equal(jid.join("a", nil, "c"), nil, "invalid JID is nil"); end); + it("should reject invalid arguments", function () + assert.has_error(function () jid.join(false, "bork", nil) end) + assert.has_error(function () jid.join(nil, "bork", false) end) + assert.has_error(function () jid.join(false, false, false) end) + end) end); describe("#split()", function() it("should work", function() @@ -38,6 +43,9 @@ describe("util.jid", function() test("@server/resource", nil, nil, nil); test("@/resource", nil, nil, nil); end); + it("should reject invalid arguments", function () + assert.has_error(function () jid.split(false) end) + end) end); @@ -59,6 +67,9 @@ describe("util.jid", function() assert.are.equal(jid.bare("user@@host/resource"), nil, "invalid JID is nil"); assert.are.equal(jid.bare("user@host/"), nil, "invalid JID is nil"); end); + it("should reject invalid arguments", function () + assert.has_error(function () jid.bare(false) end) + end) end); describe("#compare()", function() -- cgit v1.2.3