From 6b4c1ca955b953e05b4c4a56177142b19ecb3534 Mon Sep 17 00:00:00 2001 From: Matthew Wild Date: Thu, 17 Mar 2016 19:08:42 +0000 Subject: util.cache: Change behaviour of on_evict (and tests). Now accepts false instead of a function (never evict), or on_evict can return false to prevent eviction. --- util/cache.lua | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'util/cache.lua') diff --git a/util/cache.lua b/util/cache.lua index e53bf4bf..074916cd 100644 --- a/util/cache.lua +++ b/util/cache.lua @@ -51,10 +51,13 @@ function cache_methods:set(k, v) return true; end -- Check whether we need to remove oldest k/v - local on_evict, evicted_key, evicted_value; if self._count == self.size then local tail = self._tail; - on_evict, evicted_key, evicted_value = self._on_evict, tail.key, tail.value; + local on_evict, evicted_key, evicted_value = self._on_evict, tail.key, tail.value; + if on_evict ~= nil and (on_evict == false or on_evict(evicted_key, evicted_value) == false) then + -- Cache is full, and we're not allowed to evict + return false; + end _remove(self, tail); self._data[evicted_key] = nil; end @@ -62,9 +65,6 @@ function cache_methods:set(k, v) m = { key = k, value = v, prev = nil, next = nil }; self._data[k] = m; _insert(self, m); - if on_evict and evicted_key then - on_evict(evicted_key, evicted_value, self); - end return true; end -- cgit v1.2.3