From 4abc78fb2f0df4eb60fa62b8b7d79a7c361646d7 Mon Sep 17 00:00:00 2001 From: Kim Alvefur Date: Tue, 8 Jun 2021 00:58:27 +0200 Subject: util.openmetrics: Prettify format of histogram buckets "%g" turns 1GB into 1.07374e+09, which is a bit awkward for the bytes measurements IMO. Turning up the precision, at "%.17g" turns 0.1 into 0.10000000000000001 while "%0.16" gives 0.1, hiding most of those pesky floating point artefacts. Lua version 5.2 uses "%.14g" ( see LUA_NUMBER_FMT in luaconf.h.html ) so it seems like a sensible choice here. --- util/openmetrics.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'util/openmetrics.lua') diff --git a/util/openmetrics.lua b/util/openmetrics.lua index 299b36c7..90d3fdc2 100644 --- a/util/openmetrics.lua +++ b/util/openmetrics.lua @@ -58,7 +58,7 @@ local function render_histogram_le(v) return "+Inf" end - return string.format("%g", v) + return string.format("%.14g", v) end -- BEGIN of generic MetricFamily implementation -- cgit v1.2.3