aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Wild <mwild1@gmail.com>2022-10-07 11:35:56 +0100
committerMatthew Wild <mwild1@gmail.com>2022-10-07 11:35:56 +0100
commit01e03f483760c6f0ff7c6f15fe9cd6b6a54ee97b (patch)
treec35ae44938fe50809b0d3538b3f2a67118e3402e
parent08b49654d9bfd6a280e336d834f4bcfee8bda8e1 (diff)
downloadprosody-01e03f483760c6f0ff7c6f15fe9cd6b6a54ee97b.tar.gz
prosody-01e03f483760c6f0ff7c6f15fe9cd6b6a54ee97b.zip
mod_smacks: Change boolean attribute from '1' to 'true' for compatibility
Conversations 2.10.10 and earlier expect this to be literally 'true' and don't recognise '1'. This leads to it not attempting resumption with Prosody at all since this change was introduced in 36ba170c4fd0. Thanks to Zash for noticing, debugging and diagnosing this issue. This issue is fixed in Conversations commit 052c58f3 (unreleased at the time of writing).
-rw-r--r--plugins/mod_smacks.lua2
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/mod_smacks.lua b/plugins/mod_smacks.lua
index 08ebcfec..ee537b0d 100644
--- a/plugins/mod_smacks.lua
+++ b/plugins/mod_smacks.lua
@@ -354,7 +354,7 @@ function handle_enable(session, stanza, xmlns_sm)
(session.sends2s or session.send)(st.stanza("enabled", {
xmlns = xmlns_sm;
id = enabled.id;
- resume = enabled.id and "1" or nil;
+ resume = enabled.id and "true" or nil; -- COMPAT w/ Conversations 2.10.10 requires 'true' not '1'
max = enabled.resume_max;
}));