aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWaqas Hussain <waqas20@gmail.com>2009-10-04 22:12:12 +0500
committerWaqas Hussain <waqas20@gmail.com>2009-10-04 22:12:12 +0500
commit1d7b68a237147803acfc2829cb5e0c4b44253618 (patch)
treea4afb14eba6ee5a0299aa675261ba63e569c4bca
parentc6ec71bee0acf47e0581ad0c1dad2ed47b59dc8a (diff)
parent269a562f52e2d404c4d49122436029d07d17711c (diff)
downloadprosody-1d7b68a237147803acfc2829cb5e0c4b44253618.tar.gz
prosody-1d7b68a237147803acfc2829cb5e0c4b44253618.zip
Merge with 0.5
-rw-r--r--core/rostermanager.lua31
-rw-r--r--core/stanza_router.lua6
2 files changed, 24 insertions, 13 deletions
diff --git a/core/rostermanager.lua b/core/rostermanager.lua
index 0163e343..33fcf97a 100644
--- a/core/rostermanager.lua
+++ b/core/rostermanager.lua
@@ -102,9 +102,16 @@ function load_roster(username, host)
return roster;
end
-function save_roster(username, host)
+function save_roster(username, host, roster)
log("debug", "save_roster: saving roster for "..username.."@"..host);
- if hosts[host] and hosts[host].sessions[username] and hosts[host].sessions[username].roster then
+ if not roster then
+ roster = hosts[host] and hosts[host].sessions[username] and hosts[host].sessions[username].roster;
+ --if not roster then
+ -- --roster = load_roster(username, host);
+ -- return true; -- roster unchanged, no reason to save
+ --end
+ end
+ if roster then
local roster = hosts[host].sessions[username].roster;
roster[false].version = (roster[false].version or 1) + 1;
return datamanager.store(username, host, "roster", hosts[host].sessions[username].roster);
@@ -123,7 +130,7 @@ function process_inbound_subscription_approval(username, host, jid)
item.subscription = "both";
end
item.ask = nil;
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
end
@@ -145,7 +152,7 @@ function process_inbound_subscription_cancellation(username, host, jid)
end
end
if changed then
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
end
@@ -167,7 +174,7 @@ function process_inbound_unsubscribe(username, host, jid)
end
end
if changed then
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
end
@@ -189,7 +196,7 @@ function set_contact_pending_in(username, host, jid, pending)
end
if not roster.pending then roster.pending = {}; end
roster.pending[jid] = true;
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
function is_contact_pending_out(username, host, jid)
local roster = load_roster(username, host);
@@ -208,7 +215,7 @@ function set_contact_pending_out(username, host, jid) -- subscribe
end
item.ask = "subscribe";
log("debug", "set_contact_pending_out: saving roster; set "..username.."@"..host..".roster["..jid.."].ask=subscribe");
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
function unsubscribe(username, host, jid)
local roster = load_roster(username, host);
@@ -223,7 +230,7 @@ function unsubscribe(username, host, jid)
elseif item.subscription == "to" then
item.subscription = "none";
end
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
function subscribed(username, host, jid)
if is_contact_pending_in(username, host, jid) then
@@ -240,7 +247,7 @@ function subscribed(username, host, jid)
end
roster.pending[jid] = nil;
-- TODO maybe remove roster.pending if empty
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end -- TODO else implement optional feature pre-approval (ask = subscribed)
end
function unsubscribed(username, host, jid)
@@ -262,7 +269,7 @@ function unsubscribed(username, host, jid)
end
end
if changed then
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
end
@@ -271,7 +278,7 @@ function process_outbound_subscription_request(username, host, jid)
local item = roster[jid];
if item and (item.subscription == "none" or item.subscription == "from") then
item.ask = "subscribe";
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
end
@@ -280,7 +287,7 @@ end
local item = roster[jid];
if item and (item.subscription == "none" or item.subscription == "from" then
item.ask = "subscribe";
- return datamanager.store(username, host, "roster", roster);
+ return save_roster(username, host, roster);
end
end]]
diff --git a/core/stanza_router.lua b/core/stanza_router.lua
index 41d09553..e8ade0e1 100644
--- a/core/stanza_router.lua
+++ b/core/stanza_router.lua
@@ -26,9 +26,13 @@ function core_process_stanza(origin, stanza)
-- TODO verify validity of stanza (as well as JID validity)
if stanza.attr.type == "error" and #stanza.tags == 0 then return; end -- TODO invalid stanza, log
if stanza.name == "iq" then
- if (stanza.attr.type == "set" or stanza.attr.type == "get") and #stanza.tags ~= 1 then
+ local can_reply = stanza.attr.type == "set" or stanza.attr.type == "get"
+ local missing_id = not stanza.attr.id;
+ if can_reply and (#stanza.tags ~= 1 or missing_id) then
origin.send(st.error_reply(stanza, "modify", "bad-request"));
return;
+ elseif missing_id then
+ return;
end
end