diff options
| author | Kim Alvefur <zash@zash.se> | 2021-01-24 15:57:48 +0100 |
|---|---|---|
| committer | Kim Alvefur <zash@zash.se> | 2021-01-24 15:57:48 +0100 |
| commit | 4b306202344c61af42b455d5da3840179266e1a7 (patch) | |
| tree | 0a17c5364d83ccc006726ec1a4e59bab4944f7f7 | |
| parent | dc043e287fb5c596e9754f00c1afa87dc30dad29 (diff) | |
| download | prosody-4b306202344c61af42b455d5da3840179266e1a7.tar.gz prosody-4b306202344c61af42b455d5da3840179266e1a7.zip | |
util.startup: Don't create installer plugin path (as root)
Since this runs before dropping root, the directory ends up being owned
by root, resulting in luarocks failing to install anything, since by
then it would be running as the prosody user.
luarocks creates this directory if needed, so creating it during startup
is not necessary.
One potential issue is if the directory is somewhere where Prosody can't
write, but then you will simply have to create it yourself with the
appropriate permissions.
| -rw-r--r-- | util/startup.lua | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/util/startup.lua b/util/startup.lua index 27420c57..d6e7eca1 100644 --- a/util/startup.lua +++ b/util/startup.lua @@ -271,8 +271,6 @@ function startup.setup_plugin_install_path() local path_sep = package.config:sub(3,3); -- TODO Figure out what this should be relative to, because CWD could be anywhere installer_plugin_path = config.resolve_relative_path(require "lfs".currentdir(), installer_plugin_path); - -- TODO Can probably move directory creation to the install command - require "lfs".mkdir(installer_plugin_path); require"util.paths".complement_lua_path(installer_plugin_path); -- luacheck: ignore 111 CFG_PLUGINDIR = installer_plugin_path..path_sep..(CFG_PLUGINDIR or "plugins"); |