diff options
| author | Matthew Wild <mwild1@gmail.com> | 2013-07-08 21:38:08 +0100 |
|---|---|---|
| committer | Matthew Wild <mwild1@gmail.com> | 2013-07-08 21:38:08 +0100 |
| commit | be3a4082cff9d17f8fda7d173e31c1b78521b2ee (patch) | |
| tree | cb199d278486960f43ecb1f7a0becf9aaa11ca32 | |
| parent | 3aa068db4075c4f421857eca77aac0e5ba4e7042 (diff) | |
| download | prosody-be3a4082cff9d17f8fda7d173e31c1b78521b2ee.tar.gz prosody-be3a4082cff9d17f8fda7d173e31c1b78521b2ee.zip | |
mod_component: xpcall() stanza processing, as per other listeners, preventing potentially harmful 'top-level errors'
| -rw-r--r-- | plugins/mod_component.lua | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/plugins/mod_component.lua b/plugins/mod_component.lua index 871a20e4..2fde57ee 100644 --- a/plugins/mod_component.lua +++ b/plugins/mod_component.lua @@ -9,6 +9,7 @@ module:set_global(); local t_concat = table.concat; +local traceback = debug.traceback; local logger = require "util.logger"; local sha1 = require "util.hashes".sha1; @@ -183,6 +184,7 @@ function stream_callbacks.streamclosed(session) session:close(); end +local function handleerr(err) log("error", "Traceback[component]: %s", traceback(tostring(err), 2)); end function stream_callbacks.handlestanza(session, stanza) -- Namespaces are icky. if not stanza.attr.xmlns and stanza.name == "handshake" then @@ -213,7 +215,10 @@ function stream_callbacks.handlestanza(session, stanza) return; end end - return core_process_stanza(session, stanza); + + if stanza then + return xpcall(function () return core_process_stanza(session, stanza) end, handleerr); + end end --- Closing a component connection |