aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKim Alvefur <zash@zash.se>2019-11-02 15:27:53 +0100
committerKim Alvefur <zash@zash.se>2019-11-02 15:27:53 +0100
commitcffb8bea9a82b514aec4ec3b479e055298c3c4bb (patch)
tree557b60702e044df2ec5f4025fa9ec341d8416214
parent00cf4fcf1414a5b633725f053c3d799b619cb2ed (diff)
downloadprosody-cffb8bea9a82b514aec4ec3b479e055298c3c4bb.tar.gz
prosody-cffb8bea9a82b514aec4ec3b479e055298c3c4bb.zip
mod_dialback: Abort early if request is missing addressing attributes
Prevents traceback from passing nil to nameprep()
-rw-r--r--plugins/mod_dialback.lua5
1 files changed, 5 insertions, 0 deletions
diff --git a/plugins/mod_dialback.lua b/plugins/mod_dialback.lua
index eddc3209..dc843498 100644
--- a/plugins/mod_dialback.lua
+++ b/plugins/mod_dialback.lua
@@ -93,6 +93,11 @@ module:hook("stanza/jabber:server:dialback:result", function(event)
-- he wants to be identified through dialback
-- We need to check the key with the Authoritative server
local attr = stanza.attr;
+ if not attr.to or not attr.from then
+ origin.log("debug", "Missing Dialback addressing (from=%q, to=%q)", attr.from, attr.to);
+ origin:close("improper-addressing");
+ return true;
+ end
local to, from = nameprep(attr.to), nameprep(attr.from);
if not hosts[to] then