aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Wild <mwild1@gmail.com>2009-05-26 01:27:07 +0100
committerMatthew Wild <mwild1@gmail.com>2009-05-26 01:27:07 +0100
commite76bc541aa96c70ddb4f814f394111b653fa026b (patch)
tree3964e1f428e7b1a47d12644b74422da5665793fe
parent7804582f2a401da0edf284072ae22e46e5196a13 (diff)
downloadprosody-e76bc541aa96c70ddb4f814f394111b653fa026b.tar.gz
prosody-e76bc541aa96c70ddb4f814f394111b653fa026b.zip
mod_roster: Add some comments for the error cases to improve readability
-rw-r--r--plugins/mod_roster.lua6
1 files changed, 6 insertions, 0 deletions
diff --git a/plugins/mod_roster.lua b/plugins/mod_roster.lua
index 13ba8c99..bdc9a233 100644
--- a/plugins/mod_roster.lua
+++ b/plugins/mod_roster.lua
@@ -114,19 +114,25 @@ module:add_iq_handler("c2s", "jabber:iq:roster",
end
local success, err_type, err_cond, err_msg = rm_add_to_roster(session, jid, r_item);
if success then
+ -- Ok, send success
session.send(st.reply(stanza));
+ -- and push change to all resources
rm_roster_push(from_node, from_host, jid);
else
+ -- Adding to roster failed
session.send(st.error_reply(stanza, err_type, err_cond, err_msg));
end
end
else
+ -- Trying to add self to roster
session.send(st.error_reply(stanza, "cancel", "not-allowed"));
end
else
+ -- Invalid JID added to roster
session.send(st.error_reply(stanza, "modify", "bad-request")); -- FIXME what's the correct error?
end
else
+ -- Roster set didn't include a single item, or its name wasn't 'item'
session.send(st.error_reply(stanza, "modify", "bad-request"));
end
return true;