aboutsummaryrefslogtreecommitdiffstats
path: root/spec/scansion/pep_publish_subscribe.scs
diff options
context:
space:
mode:
authorMatthew Wild <mwild1@gmail.com>2020-03-12 14:10:12 +0000
committerMatthew Wild <mwild1@gmail.com>2020-03-12 14:10:12 +0000
commite30cbeae993803583e1f2ed2085c9be5b5fb6f63 (patch)
treed6a10e241ccab42b3192a24ecb3ade48a9b53d7a /spec/scansion/pep_publish_subscribe.scs
parentd04da8fdd9c278f3e987af71208ea5865d11c54b (diff)
downloadprosody-e30cbeae993803583e1f2ed2085c9be5b5fb6f63.tar.gz
prosody-e30cbeae993803583e1f2ed2085c9be5b5fb6f63.zip
MUC: Pass previous role to :publicise_occupant_status() whenever possible
Currently there is what amounts to a hack in presence_broadcast.lib.lua to make it always broadcast presence with roles of "none". This is to ensure that if you previously saw available presence for someone, you will also see the unavailable presence (which always has role="none"). The correct approach is to take into account what the previous role was ( i.e. answer the question: "Was the available presence for this occupant a role for which presence broadcast is enabled?). The logic is already in place to do this correctly, but most call sites do not provide the previous role (prev_role argument) of the occupant, which causes it to not be used. In its place the hack to always broadcast presence of role="none" has allowed things to continue to work. The intention is that a subsequent commit will remove the unconditional broadcast of role="none".
Diffstat (limited to 'spec/scansion/pep_publish_subscribe.scs')
0 files changed, 0 insertions, 0 deletions